WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 9 months ago

Last modified 9 months ago

#16866 closed enhancement (fixed)

Multisite registration uses extra redirect

Reported by: spathon Owned by: spathon
Milestone: 3.5 Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: close
Focuses: Cc:

Description

When you are on a sub-blogg and choose register you are sent to wp-login.php?action=register and because it is a multisite it redirects to wp-signup.php. wp-signup.php then redirects to wp-signup.php on the main site.

if

wp_redirect( apply_filters( 'wp_signup_location', site_url('wp-signup.php') ) ); // row 488 in wp-login.php

were set to network_home_url instead of site_url there would be one less redirects and risk for plugins to cause problems.

Change History (5)

comment:1 hakre3 years ago

Thanks for taking the time to report your issue.

Generally spoken you can have a number of redirects after each other, that's not a problem per-se. Browsers can deal pretty well with that, at least from what I've learned over the last years, I never had a problem with a redirect chain unless you don't create a loop.

It might be seen as a waste of resources as the application needs to get loaded another time to just generate the second redirect but I have no idea how much overhead that really is I must admit.

However, I won't consider a redirect a risk for plugin to cause problems. If a plugin is breaking the first redirect, then the plugin already is problematic regardless how many redirects are chained.

If you run into a problem regarding a plugin and redirect please tell more about that problem. What's the risk you're fearing? Such additional feedback might lead to a far better solution, that's why I ask.

comment:2 spathon3 years ago

  • Owner set to spathon
  • Status changed from new to reviewing

Just thought if the there isn't any special reason why not make one useless server load when there would be an easy fix?

I just had a problem with a membership plugin that i use to blocks part of the site and the plugin uses an hook or something before the redirect so the redirect newer happens.

comment:3 SergeyBiryukov3 years ago

  • Keywords needs-patch added

comment:4 fjarrett9 months ago

  • Cc fjarrett@… added
  • Keywords close added; needs-patch removed
  • Resolution set to invalid
  • Status changed from reviewing to closed

This was fixed in [21813]

comment:5 helen9 months ago

  • Milestone changed from Awaiting Review to 3.5
  • Resolution changed from invalid to fixed
Note: See TracTickets for help on using tickets.