WordPress.org

Make WordPress Core

Opened 17 years ago

Closed 17 years ago

#169 closed defect (bug) (invalid)

get_links_list() in wp-includes/links.php ignores $text_after_link settings

Reported by: Froosh Owned by: matt
Milestone: Priority: normal
Severity: trivial Version: 1.2
Component: Template Keywords:
Focuses: Cc:

Description

Out of the box, index.php (which calls get_links_list()) does not use any $text_after_link (text between link and description) settings that you specify in link categories (Not even the default <br />).

I have attached a diff to links.php that resolves this minor problem.

Attachments (1)

0000169-links.php.diff (1.1 KB) - added by Froosh 17 years ago.

Download all attachments as: .zip

Change History (8)

#2 @Froosh
17 years ago

A quick browse of the rest of the code in links.php reveals that get_links_list() is the only function that ignores text_before_link, text_after_link and text_after_all properties.

#3 @dennis
17 years ago

I'm bumping this because it was addressed in links.php CVS 1.12.4.1 but removed in 1.12.4.2

#4 @2fargon
17 years ago

  • Patch set to Yes
  • Status changed from new to assigned

#5 @ryan
17 years ago

get_links_list() is purposely hard-coded to use list items. That's why it is get_links_*list*. You can use wp_get_links() if you want to use the DB defaults. That method can be modified to allow listing all link categories rather than just one. Or, we can deprecate all of the link settings junk and clear that cruft out of the links UI.

#6 @Froosh
17 years ago

Ok, that makes sense.

Should this instead be a request that wp-sidebar use wp_get_links() rather than get_links_list()?

From a user-experience point of view it's very frustrating when changing the settings in Link Categories and seeing zero change in the site.

I would prefer see the link separators stay and be implemented rather than be removed altogether. Not that I'm even using them at the moment... :)

#7 @matt
17 years ago

  • Owner changed from anonymous to matt
  • Resolution changed from 10 to 70
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.