WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#16901 closed enhancement (invalid)

Minor changes to theme install page

Reported by: Simek Owned by: scribu
Milestone: Priority: normal
Severity: minor Version: 3.1
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

I've prepared minor changes to Theme Install page. Some basic stuff at the moment.

I've also got a question about "theme" object and his attributes. There are a lot of "!empty" conditionals for attributes but when I've used var_dump on "theme" part of the just don't exist. It's a mistake or I've miss something?

I would like also continue my work to unify UI/apperance of Manage Themes and Install Theme pages.

Attachments (1)

theme-install.patch (3.1 KB) - added by Simek 5 years ago.

Download all attachments as: .zip

Change History (6)

@Simek
5 years ago

#1 follow-up: @dd32
5 years ago

There are a lot of "!empty" conditionals for attributes but when I've used var_dump on "theme" part of the just don't exist. It's a mistake or I've miss something?

The case is that not all themes have the data I'd suggest.

#2 in reply to: ↑ 1 @Simek
5 years ago

Replying to dd32:

There are a lot of "!empty" conditionals for attributes but when I've used var_dump on "theme" part of the just don't exist. It's a mistake or I've miss something?

The case is that not all themes have the data I'd suggest.

It's strange that Twenty Ten also don't have this data.

#3 @scribu
5 years ago

  • Owner set to scribu
  • Status changed from new to reviewing

Please be more descriptive: What do these minor changes do? What are you trying to accomplish?

#4 @Simek
5 years ago

At the moment patch introduce:

  • better (in loop) themes stars rating generation
  • provides modified way of display when theme was updated
  • themes descriptions justified

My goal is to unify and improve usablity of the UI and way of content display for Installed Themes and Theme Browser.

#5 @scribu
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from reviewing to closed

The theme install code was unified at some point, so the patch is no longer relevant.

Sorry, Simek.

Note: See TracTickets for help on using tickets.