sanitize_title calls remove_accents before applying filters

[texttheater]

As of r15929, sanitize_title in formatting.php calls remove_accents directly. remove_accents used to be called in sanitize_title_with_dashes, which in turn is one of the default filters applied in sanitize_title. The change takes away the possibility for plugins to change the title using a filter before accents are removed, or to avoid removing accents altogether.

One of the plugins broken by the change is my ​German Slugs.

Related tickets:

• #9591, where the change originated
• #15248, where unsalkorkmaz has a similar complaint that could at least have been worked around before the change, now there seems to be no chance to do so using the plugin API
• #9492, where the deeper issue with WordPress indiscriminately removing diacritics (that's right, not all diacritics are mere accents, remove_accents is a misnomer) is addressed. With that I think one can live – as long as it remains possible to fix it via the plugin API.

[hakre]

Gotta take a look, thanks for reporting.

Related: #9492

[hakre]

make remove_accent() filterable

[hakre]

That's just a first idea. This does not re-instates the default behaviour and I think it's of general limited use.

For me it's unclear right now when remove_accents() had been invoked previously.

[hakre]

Call sanitize title prior remove_accents

[hakre]

$raw_title is available as second parameter passed to the sanitize_title filter.

AFAIK it has the original title and should help you to override any changes remove_accent() already has done.

Isn't it suitable for your workarounds?

[hakre]

Just an idea

[hakre]

Probably it's better to normalize the data in remove_accents() and make the transliteration table overload-able - Related: #16908

[toscho]

See #16642 for a discussion of this issue and ​my code for a solution. No need to change anything.

[ocean90]

#16642

[texttheater]

Thanks for pointing me to $raw_title, that does make a workaround possible.