WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 8 months ago

#16934 closed enhancement (fixed)

Commented code in /wp-includes/canonical.php

Reported by: hakre Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.1
Component: Canonical Keywords: has-patch commit
Focuses: Cc:

Description

Timestamp: 10/16/08 19:17:04 (2 years) - Safe to remove this by now?

[9203]

Attachments (2)

16934.patch (639 bytes) - added by hakre 5 years ago.
trivial to patch
16934.2.patch (694 bytes) - added by chriscct7 8 months ago.

Download all attachments as: .zip

Change History (10)

#1 @hakre
5 years ago

Related: #8593

@hakre
5 years ago

trivial to patch

#2 @kawauso
5 years ago

  • Keywords has-patch added

#3 @iseulde
3 years ago

  • Component changed from General to Inline Docs

#4 follow-up: @DrewAPicture
3 years ago

  • Milestone changed from Awaiting Review to 3.7

Looks like both #5017 and #7173 are fixed, is this still pertinent information?

#5 in reply to: ↑ 4 @nacin
3 years ago

  • Component changed from Inline Docs to Canonical
  • Milestone changed from 3.7 to Awaiting Review

Replying to DrewAPicture:

Looks like both #5017 and #7173 are fixed, is this still pertinent information?

It seems like this was commented out due to #5017 / #7173, rather than being "fixed" by those tickets.

@chriscct7
8 months ago

#6 @chriscct7
8 months ago

  • Keywords commit added; dev-feedback removed
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to chriscct7
  • Status changed from new to accepted
  • Type changed from defect (bug) to enhancement

#7 @DrewAPicture
8 months ago

  • Owner changed from chriscct7 to wonderboymusic
  • Status changed from accepted to assigned

#8 @wonderboymusic
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34734:

Canonical: remove unused code (commented-out) from redirect_canonical().

Props hakre, chriscct7.
Fixes #16934.

Note: See TracTickets for help on using tickets.