Add filter to selected text in press-this.php

[topdownjimmy]

When using the "Press This" bookmarklet, any text selected on the current page is inserted into the post body textarea. This should be wrapped in a <blockquote> tag with some appropriate class name.

[ldebrouwer]

Added blockquotes to the "Press This" content.

[ldebrouwer]

I didn't add a class, I did add the cite attribute. However this still needs an okay from higher up for the feature request to be honored. I can see the 'need' for this because why would anybody want to copy content from a different website without a <blockquote>, unless they're stealing content ;)

[topdownjimmy]

Would "press-this-selection" be an appropriate class name?

[topdownjimmy]

Added blockquote with "press-this-selection" class

[topdownjimmy]

Just added another patch including your changes plus the class "press-this-selection"

This is my first time contributing a patch so I hope I've done it correctly.

[topdownjimmy]

Ha, already screwed that up. I used double quotes where I should have used single quotes. New patch corrected and uploaded. Apologies.

[topdownjimmy]

Previous patch fixed to include single quotes instead of double quotes on class name

[ocean90]

Related: #16935

[jane]

For the record, I would love selected area to automatically get blockquoted.

[c3mdigital]

I would rather see a filter for $selection than forcing it in blockquotes. Many different uses out there for press-this. Let the theme or end user decide how front end content gets marked up. I'm closing as wont fix please reopen if you have any further thoughts.

[SergeyBiryukov]

Feel free to reopen with a patch adding a filter for $selection.

[topdownjimmy]

Any styling hook would be beneficial, I think -- just *something* to allow Press This to be more effortless.

I'm not sure what you mean by adding a filter for $selection, however.

[c3mdigital]

Replying to topdownjimmy:

Any styling hook would be beneficial, I think -- just *something* to allow Press This to be more effortless.

I'm not sure what you mean by adding a filter for $selection, however.

$selection is the variable that holds the selected text that gets added to the editor. Adding a filter (see: ​patch) will allow you to wrap any html you wanted around it.

[c3mdigital]

Filter for selected text

[helen]

I don't know how useful this filter really is as it stands - you're going to be string replacing or ​regex-ing HTML and praying no other filters are there. It should pass the original $selection for context, probably, so one could just wrap that with whatever.

[kraftbj]

Fixed in the Press This Revamp in [31534] via #31373.

See https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/press-this.js?rev=31534#L229