Dead code in add_query_arg()

[hakre]

As it just has been checked that $uri contains at least one ?, then exploding $uri on ? with a limit of 2 must return two elements, right?

	if ( strpos( $uri, '?' ) !== false ) {
		$parts = explode( '?', $uri, 2 );
		if ( 1 == count( $parts ) ) {

So the if clause can never be true, the code is dead.

[hakre]

Stripping the dead.

[scribu]

Shouldn't add_query_arg() be using parse_url() ?

[scribu]

I guess not, since parse_url() doesn't work with relative URLs.

[dd32]

Looks right with the edgecases of ?test and test.php?, an empty item will be returned before, and after respectively, resulting in always having a count of 2.

[hakre]

Related: #16958

[c3mdigital]

Refresh of Hakre's patch

[wonderboymusic]

In 25333:

Remove dead code in add_query_arg().

Props hakre, c3mdigital.
Fixes #16942.