#16958 closed defect (bug) (fixed)
Dead Code in WP_Http::processResponse()
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 3.2 | Priority: | lowest |
| Severity: | trivial | Version: | 3.1 |
| Component: | HTTP API | Keywords: | has-patch |
| Focuses: | Cc: |
Description
See patch.
Attachments (1)
Change History (5)
#1
follow-up:
↓ 2
@
14 years ago
- Component changed from General to HTTP
- Priority changed from normal to lowest
- Severity changed from minor to trivial
Is this an actual bug? http://wpdevel.wordpress.com/2011/03/23/code-refactoring/
#2
in reply to:
↑ 1
@
14 years ago
Replying to dd32:
Is this an actual bug? http://wpdevel.wordpress.com/2011/03/23/code-refactoring/
I rate dead code as a bug if the code in question does not give any enhance but instead only consumes. Bugs have not much in common with the issue about applying coding standards you referenced.
I think once reported it is often easy to fix and make the code lighter. But it's not that I report them out of the blue.
I normally spot those while reviewing code in other tickets, so I think those are worth to report. Maybe we can have a family ticket for those. It's just like how I find those: 16978.patch which for example already has been committed. It's just not that always there is a ticket already to add the patch to.
So maybe we should turn this into a collecting ticket a core dev can review each some days.
first member of array will always be set by the explode command.