WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16959 closed defect (bug) (maybelater)

Core HTTP Transports implementation can support $url in test().

Reported by: hakre Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: HTTP API Keywords: has-patch
Focuses: Cc:

Description

A sort of Follow-Up: With [17550], those functions are called with the addiotnal $url parameter. I think the change is useful.

Attachments (1)

16959.patch (1.5 KB) - added by hakre 3 years ago.
adding $url

Download all attachments as: .zip

Change History (5)

hakre3 years ago

adding $url

comment:1 hakre3 years ago

Related: #11613

comment:2 dd323 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

When it's needed, or is useful, it's available.

comment:3 dd323 years ago

Backstory: It was originally added for the purpose of proxy-blocking in the streams or fopen transport, but since we now require PHP5.2.4, it was no longer needed (And I forgot to remove it from the called location)

Since it neither adds, or removes functionality/need, theres no need for a change here

comment:4 hakre3 years ago

My Backstory: I didn't know it's passed to there as it was hidden in code. But it's good to know as test() implementations still can actually benefit from it.

Actually I was looking for it earlier today in #16606, passing of the URL allows to check for the actual stream transport. So I've added another patch: 16606.3.patch

Note: See TracTickets for help on using tickets.