Creation of .htaccess file leads to a 500 Error

[hakre]

Turning on permalinks can render the whole blog into a 500 error situation under certain conditions.

The issue has been experienced with a WP 3.0.5 setup, other versions seem affected as well.

The creation of the .htaccess file does not reflect the systems umask setting which can result in creating a file that is not accessible by the server.

That triggers the 500 then.

Normally WP chmod's all files it creates. This is not done with the .htaccess file if it did not existed already.

[hakre]

Patch against trunk.

I'm not sure if FS_CHMOD_FILE is the correct value to refer to, for my case the 0644 (rw-r--r) would have done it which is the default for FS_CHMOD_FILE.

Related: #10170

[ramoonus]

you say it also happens in other versions than 3.0.5
does that include 3.1?

[hakre]

Replying to ramoonus:

you say it also happens in other versions than 3.0.5
does that include 3.1?

I said: "other versions seem affected as well".

I'm sure that ​3.1 is affected as well as the code looks the same.

[hakre]

The flow in that function could be simplified to first check if a file exists or not and handle everything related to file creation upfront.

See the example attached which demonstrates this next to the following:

Then the replacement of the area(s) defined by $marker could be buffered and thanks to that simplified as well.

The second benefit of a buffer is that it can be written buffered to disc reducing I/O.

The function can benefit from defining the input variables, it's a bit unclear if $insertion must or can be an array. Not addressed in the example, just came to my mind.

[hakre]

Example only

[ramoonus]

Replying to hakre:

Replying to ramoonus:

you say it also happens in other versions than 3.0.5
does that include 3.1?

I said: "other versions seem affected as well".

I'm sure that ​3.1 is affected as well as the code looks the same.

[nacin]

OP said he could reproduce this on the 3.0 branch.

[ocean90]

#18142

[chriscct7]

Good first bug: Report if can reproduce

[AndrewNatoli]

I tried reproducing this on a few environments with several different settings but was unsuccessful. Even using the noted FS_CHMOD_FILE setting and forcing umask() before this was called wouldn't cause the issue. If I just couldn't write to the directory in general, I would be told to manually create the .htaccess file as expected.

Tested 3.0.3 & 3.0.5