wp_notify_postauthor() pluggable behavior problem

[dglingren]

In my application a notification must be issued even when an author comments on their own post; this is not allowed by the default WordPress implementation. Lines 1015 - 1025 in function wp_notify_postauthor reject the author's comments and moderations.
Since wp_notify_postauthor is a pluggable function, I can change this behavior by implementing my own function and replacing the default.

However, there is also a redundant test of post authorship in wp-includes/comment.php, function wp_new_comment, around lines 1344 - 1348. This means that my custom wp_notify_postauthor is never called. My specific problem can be solved by commenting out a line of code:

// $post = &get_post($commentdata['comment_post_ID']); // Don't notify if it's your own comment

A real fix for this problem should move all of the user_id validation rules out of wp_new_comment and put them in wp_notify_postauthor where they can be modified as needed.

[scribu]

It's not a good idea to lump two issues in the same ticket.

Please open a new ticket for the first issue.

[solarissmoke]

Patch makes behaviour consistent with wp_notify_moderator(), where the notify option is checked inside the function. This allows complete override by a custom function.

[dglingren]

Thanks for the quick action. I have applied this patch to my install and it seems to work fine.

I have opened Ticket #17001 for the "From:" issue; thanks for your guidance.

[scribu]

@solarissmoke: ​Coding standards:

Instead of:

if(

it should be:

if (

Easier to prevent than to cure. ;-)

While you're at it, you can also add spacing to these lines:

$comment = get_comment($comment_id); 
wp_notify_postauthor($comment_id, $comment->comment_type);

[solarissmoke]

All nicely spaced :)

[solarissmoke]

@scribu: done, and added a few spaces elsewhere while I was at it

[chriscct7]

Duplicate of #25699.