Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#16999 closed defect (bug) (fixed)

BUG: child pages slug with non-english charecters

Reported by: ramiy Owned by: ramiy
Milestone: 3.2 Priority: normal
Severity: major Version: 3.1.3
Component: Administration Keywords: has-patch
Focuses: Cc:

Description (last modified by yoavf)

(Related #10966 - same problem in other admin pages)

I found one more bug when creating a child page using slug with non-english characters.

I added a screenshot from a client site using WordPress in hebrew (RTL language).

To recreate the problem in an english installation (LTR language), create a new page called "internationalizætiøn-parent", and then create a child page called "internationalizætiøn-child".

Attachments (3)

slug-bug.png (65.6 KB) - added by ramiy 5 years ago.
wrong parent slug
16999.diff (510 bytes) - added by solarissmoke 5 years ago.
Pass parent page slug(s) through editable_slug filter before inserting them into the permalink
bbPress-problem.PNG (42.6 KB) - added by ramiy 4 years ago.
Better visual example using bbPress plugin

Download all attachments as: .zip

Change History (13)

@ramiy5 years ago

wrong parent slug

comment:1 @ramiy5 years ago

Related #6915

comment:2 @solarissmoke5 years ago

  • Keywords has-patch added; needs-patch needs-ui removed

@solarissmoke5 years ago

Pass parent page slug(s) through editable_slug filter before inserting them into the permalink

comment:3 @ramiy5 years ago

  • Owner set to ramiy
  • Status changed from new to accepted

Patch tested - it's working.

comment:4 @yoavf5 years ago

  • Cc yoavf added

@ramiy4 years ago

Better visual example using bbPress plugin

comment:5 @ramiy4 years ago

  • Version changed from 3.1 to 3.1.3

On the bbPress context this ticket related to #17598. Both tickets need to be fixed before the final release of bbPress.

comment:6 @yoavf4 years ago

  • Description modified (diff)

solarissmoke's patch tested, works (small offset when applying, but no problem other than that).

comment:7 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2

comment:8 @ryan4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18105]:

Apply editable_slug filter to parent page slugs in get_sample_permalink(). Props solarissmoke, ramiy. fixes #16999

comment:9 @ramiy4 years ago

UPDATE: tested on wp3.2-RC1

The problem fixed for parent/child pages, but not for the bbpress plugin when using non-english forum slug.

comment:10 @johnjamesjacoby4 years ago

Will investigate. Thanks for cross posting.

Note: See TracTickets for help on using tickets.