WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17004, comment 6


Ignore:
Timestamp:
03/31/11 23:11:47 (4 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17004, comment 6

    initial v1  
    1 17004.2.diff looks good, I was with the impression that similar functionality already was in jQuery. Maybe consider opening an enhancement ticket on jQuery's trac, it would be useful to have a native way of escaping selectors as that's a limitation in jQuery (in HTML option value can contain CDATA). 
     1@jacobwg 17004.2.diff looks good, I was with the impression that similar functionality already was in jQuery. Maybe consider opening an enhancement ticket on jQuery's trac, it would be useful to have a native way of escaping selectors as that's a limitation in jQuery (in HTML option value can contain CDATA). 
    22 
    3 However I think #10030 and [13539] that brought this issue in the first place can be optimized a bit. Perhaps that block of code can be simplified to compare the user entered values instead of repeatedly checking for duplicates in the already created `<option value="...">`. 
     3However I think #10030 and [13539] that brought this issue in the first place can be optimized a bit. Perhaps that block of code can be simplified to compare the user entered values instead of repeatedly checking for duplicates in the already created `<option value="...">`. That will also resolve this ticket.