WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#17013 closed enhancement (duplicate)

Make $key argument optional in get_*_meta()

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit 2nd-opinion
Focuses: Cc:

Description

Altough the $key argument is optional in get_metadata(), it's not optional in the wrapper functions for some reason.

This should be fixed.

Attachments (2)

17013.diff (2.7 KB) - added by scribu 4 years ago.
17013.2.diff (2.7 KB) - added by scribu 4 years ago.
Rename $key to $meta_key

Download all attachments as: .zip

Change History (8)

comment:1 @scribu4 years ago

Related: #15483

comment:2 @scribu4 years ago

  • Keywords has-patch commit added; needs-patch removed

@scribu4 years ago

comment:3 @hakre4 years ago

Take care with renaming @param string $meta_key while not renaming $key in the functions' signatures. Looks like a copy&paste glitch.

$meta_key says more btw, so I wouldn't mind if you even rename the parameter names in the signature.

@scribu4 years ago

Rename $key to $meta_key

comment:4 @markjaquith4 years ago

  • Keywords 2nd-opinion added

No objection here.

comment:5 @ryan4 years ago

  • Milestone changed from 3.2 to Future Release

comment:6 @scribu3 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Those who can't search through trac tickets are bound to re-create them: #19882

Note: See TracTickets for help on using tickets.