Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#17013 closed enhancement (duplicate)

Make $key argument optional in get_*_meta()

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit 2nd-opinion
Focuses: Cc:


Altough the $key argument is optional in get_metadata(), it's not optional in the wrapper functions for some reason.

This should be fixed.

Attachments (2)

17013.diff (2.7 KB) - added by scribu 5 years ago.
17013.2.diff (2.7 KB) - added by scribu 5 years ago.
Rename $key to $meta_key

Download all attachments as: .zip

Change History (8)

#1 @scribu
5 years ago

Related: #15483

#2 @scribu
5 years ago

  • Keywords has-patch commit added; needs-patch removed

5 years ago

#3 @hakre
5 years ago

Take care with renaming @param string $meta_key while not renaming $key in the functions' signatures. Looks like a copy&paste glitch.

$meta_key says more btw, so I wouldn't mind if you even rename the parameter names in the signature.

5 years ago

Rename $key to $meta_key

#4 @markjaquith
5 years ago

  • Keywords 2nd-opinion added

No objection here.

#5 @ryan
5 years ago

  • Milestone changed from 3.2 to Future Release

#6 @scribu
4 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Those who can't search through trac tickets are bound to re-create them: #19882

Note: See TracTickets for help on using tickets.