WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 14 months ago

#17032 closed enhancement (wontfix)

Twenty Ten Theme - Widget Enhancement

Reported by: rozani Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

separate twentyten_widget_innit into twentyten_sidebar_widget_innit and twentyten_footer_widget_innit for the ease of child theme creation

Attachments (1)

widget.diff (6.6 KB) - added by rozani 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 rozani3 years ago

separate twentyten_widget_innit into twentyten_sidebar_widget_innit and twentyten_footer_widget_innit for the ease of child theme creation.

Draftly, modification as below. For details, see attachment.

Original widget function:

function twentyten_widgets_init() {

Separate widget function to sidebar and footer

function twentyten_sidebar_widgets_init() {
function twentyten_footer_widgets_init() {

Also, change the innit function.
Originally.

add_action( 'widgets_init', 'twentyten_widgets_init' );
{{{

Separate innit to sidebar innit and footer innit.
}}}
add_action( 'widgets_init', 'twentyten_sidebar_widgets_init' );
add_action( 'widgets_init', 'twentyten_footer_widgets_init' );

rozani3 years ago

comment:2 kawauso3 years ago

Wouldn't this break any existing child themes expecting 'twentyten_widgets_init' ?

comment:3 SergeyBiryukov16 months ago

  • Component changed from General to Bundled Theme

comment:4 lancewillett14 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

It's better to have them on the same action. I think we shouldn't make a change like this.

Note: See TracTickets for help on using tickets.