E_NOTICE with WP_DEBUG when calling get_the_ID()

[tillkruess]

When get_the_ID() is called, but $post is NULL (for example on a 404 page) a E_NOTICE is caused when WP_DEBUG is set to TRUE.

[scribu]

get_the_ID() should only be called from inside The Loop.

[jtsternberg]

Curious, why should get_the_ID() only be called from inside The Loop? Seems if we addressed the notice issue, it would be a decent way to check if there is a post object available.

[SergeyBiryukov]

Replying to jtsternberg:

Seems if we addressed the notice issue, it would be a decent way to check if there is a post object available.

get_post() appears to be the correct way to check for that.

[SergeyBiryukov]

#28572 was marked as a duplicate.

[UmeshSingla]

Replying to SergeyBiryukov

get_post() appears to be the correct way to check for that.

get_post() can't be used as well, it returns the ID for the latest post on wp-signup.php, I didn't get the logic for that.

[SergeyBiryukov]

Replying to UmeshSingla:

get_post() can't be used as well, it returns the ID for the latest post on wp-signup.php, I didn't get the logic for that.

That sounds like a separate issue.

We could probably reconsider this to avoid the notice. Your patch on #28572 seems good.

[UmeshSingla]

Replying to SergeyBiryukov:

That sounds like a separate issue.

We could probably reconsider this to avoid the notice. Your patch on #28572 seems good.

Yes, I'll try too replicate the get_post() issue, If it confirms, I'll go for a separate ticket and for this ticket do i need to submit the patch here again?

[SergeyBiryukov]

Replying to UmeshSingla:

do i need to submit the patch here again?

Yes, please.

[UmeshSingla]

Fixes get_the_ID() if get_post() returns null

[UmeshSingla]

Fixes get_the_ID() if get_post() returns null

[wonderboymusic]

In 28844:

Check for the existence of $post before using it in get_the_ID(). Return false if it doesn't exist.

Props UmeshSingla.
Fixes #17034.

[johnjamesjacoby]

Similar enough to #22413 to link here.