WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 6 months ago

#17036 new defect (bug)

Theme editor shouldn't override root directory files with same names in child directories

Reported by: kawauso Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords: needs-patch, theme-editor
Focuses: administration Cc:

Description

Steps to reproduce:

  1. Create subdirectory: blogs
  2. Create file in subdirectory: index.php
  3. Try selecting Main Index Template in Theme Editor

Example is taken from BuddyPress' theme structure. get_file_description() doesn't account in any way for the presence of subdirectories since it uses basename().

Change History (6)

comment:1 @kawauso4 years ago

Duplicate: #10429 (without proper detail)

Last edited 4 years ago by kawauso (previous) (diff)

comment:2 @SergeyBiryukov4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Related: #4131

comment:4 @nacin18 months ago

  • Component changed from Administration to Themes
  • Focuses administration added

comment:5 @obenland7 months ago

  • Keywords theme-editor added

comment:6 @SergeyBiryukov6 months ago

#30663 was marked as a duplicate.

Note: See TracTickets for help on using tickets.