Opened 14 years ago
Closed 14 years ago
#17042 closed defect (bug) (fixed)
Missing closing </fieldset> in user-edit.php for "show admin bar"
Reported by: | bluntelk | Owned by: | |
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | trivial | Version: | 3.1 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description
there is a missing closing </fieldset>tag in user-edit.php in the latest release as well as the latest SVN copy.
I have attached a simple patch to fix the problem
Attachments (2)
Change History (16)
#2
@
14 years ago
- Milestone changed from Awaiting Review to 3.1.2
- Resolution fixed deleted
- Status changed from closed to reopened
Re-opening for 3.1.2 consideration
#4
@
14 years ago
3.1.1 was in RC status a few days ago, unless it's a security or critical bug, it's not worth delaying the 3.1.1 release.
I'm not basing that on the size of the change, I'm basing that on the need to not make last minute changes to releases (ie. give it a few days to mature).
#5
@
14 years ago
- Keywords fixed-major added
This keyword will hide this ticket from reports 5 and 6, as it is fixed for the major release.
#6
@
14 years ago
Since this is fixed for 3.2 and 3.1.2 is already out this can probably be closed but I'll let somebody else make that decision.
Honestly, closing this would make one less ticket in the 3.2 milestone.
#8
follow-up:
↓ 9
@
14 years ago
the patch is there
it only includes closing a html tag
less than 5 minutes work ....
no need to close this I think
#9
in reply to:
↑ 8
@
14 years ago
ramoonus: The real question isn't how much work it is, but rather "Do we want to push another 3.1.x release for this?" Maybe if we need another 3.1 release for something else this can make it in as well. Otherwise I think waiting for 3.2 would be fine.
#11
@
14 years ago
- Milestone changed from 3.1.3 to 3.2
I'm closing this as fixed in 3.2, It's not exactly a high priority bug which is going to cause problems for 99% of users; therefor, probably doesn't need a 3.1.x release
Patch to add in the missing </fieldset> tag