WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#17042 closed defect (bug) (fixed)

Missing closing </fieldset> in user-edit.php for "show admin bar"

Reported by: bluntelk Owned by:
Milestone: 3.2 Priority: normal
Severity: trivial Version: 3.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

there is a missing closing </fieldset>tag in user-edit.php in the latest release as well as the latest SVN copy.

I have attached a simple patch to fix the problem

Attachments (2)

patch.17042.txt (712 bytes) - added by bluntelk 4 years ago.
Patch to add in the missing </fieldset> tag
user-edit.php.17042.diff (774 bytes) - added by studionashvegas 4 years ago.
Diff patch - for some reason the text file gave me a "garbage" error…

Download all attachments as: .zip

Change History (16)

@bluntelk4 years ago

Patch to add in the missing </fieldset> tag

comment:1 @dd324 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17593]) Add missing closing fieldset tag. Props bluntelk. Fixes #17042 for trunk

comment:2 @dd324 years ago

  • Milestone changed from Awaiting Review to 3.1.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for 3.1.2 consideration

comment:3 @ramoonus4 years ago

don`t tell me its too much work to put this in 3.1.1

comment:4 @dd324 years ago

3.1.1 was in RC status a few days ago, unless it's a security or critical bug, it's not worth delaying the 3.1.1 release.

I'm not basing that on the size of the change, I'm basing that on the need to not make last minute changes to releases (ie. give it a few days to mature).

Last edited 4 years ago by dd32 (previous) (diff)

comment:5 @nacin4 years ago

  • Keywords fixed-major added

This keyword will hide this ticket from reports 5 and 6, as it is fixed for the major release.

comment:6 @ryanduff4 years ago

Since this is fixed for 3.2 and 3.1.2 is already out this can probably be closed but I'll let somebody else make that decision.

Honestly, closing this would make one less ticket in the 3.2 milestone.

comment:7 @nacin4 years ago

  • Milestone changed from 3.1.2 to 3.1.3

comment:8 follow-up: @ramoonus4 years ago

the patch is there
it only includes closing a html tag
less than 5 minutes work ....
no need to close this I think

comment:9 in reply to: ↑ 8 @aaroncampbell4 years ago

ramoonus: The real question isn't how much work it is, but rather "Do we want to push another 3.1.x release for this?" Maybe if we need another 3.1 release for something else this can make it in as well. Otherwise I think waiting for 3.2 would be fine.

comment:10 @ramoonus4 years ago

i dont think its worth it

comment:11 @dd324 years ago

  • Milestone changed from 3.1.3 to 3.2

I'm closing this as fixed in 3.2, It's not exactly a high priority bug which is going to cause problems for 99% of users; therefor, probably doesn't need a 3.1.x release

@studionashvegas4 years ago

Diff patch - for some reason the text file gave me a "garbage" error...

comment:12 @studionashvegas4 years ago

  • Resolution set to worksforme
  • Status changed from reopened to closed

Tested on 3.2beta1 - new patch made; works just fine.

comment:13 @nacin4 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

comment:14 @nacin4 years ago

  • Keywords fixed-major removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.