WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #17049, comment 7


Ignore:
Timestamp:
04/05/11 14:57:42 (4 years ago)
Author:
cgrymala
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #17049, comment 7

    initial v1  
    11That's a valid point, but, from what I can see, we are also using the `no-js` and `js` classes (at least within the admin area). When I disable JavaScript and visit the wp-admin area of my 3.1 installation, the body has a class of `wp-admin no-js ...` 
    22 
    3 If you think it's better for me to use `if-js` instead of `no-js`, that's certainly an easy enough change to make, but I was trying to be consistent from the get-go. 
     3If you think it's better for me to use `hide-if-js` or `hide-if-no-js` instead of `no-js`, that's certainly an easy enough change to make, but I was trying to be consistent from the get-go. 
     4 
     5In addition, I think the concept (at least, based on their names) of `hide-if-js` and `hide-if-no-js` is different than the concept of `no-js`. I'm not hiding or showing anything with JavaScript, I am simply using it to determine whether or not JavaScript is active in the browser (if it's not, we use the standard CSS pseudo-element `:hover`; if it is, we use JavaScript to add a `hover` class to items after the timeout occurs).