wpautop() not stripping <br /> tags before <p withattributes>

[rockinfree]

<hr /><p>blah
blah
blah</p>
<hr /><p class="center">blah
blah
blah</p>

Entered through the wp-admin/post.php page should become:

	<hr />

<p>blah<br />
blah<br />
blah</p>
	<hr />
<p class="center">blah<br />
blah<br />
blah</p>

On the generated page (after being processed by wpautop()), but instead becomes:

	<hr />

<p>blah<br />
blah<br />
blah</p>
	<hr /><br />
<p class="center">blah<br />
blah<br />
blah</p>

(note the extra <br /> after the second <hr /> tag)

The error is caused in functions-formatting.php wpautop():

$pee = preg_replace('!<br />(\s*</?(?:p|li|div|dl|dd|dt|th|pre|td|ul|ol)>)!', '$1', $pee);

should be:

$pee = preg_replace('!<br />(\s*</?(?:p|li|div|dl|dd|dt|th|pre|td|ul|ol)[^>]*>)!', '$1', $pee);

(Note that the original regexp is missing the [^{>]*, which is present for all other patterns in this function, and is necessary to allow, for example, <p class="center"> as in the repro case.)}

[rockinfree]

Fixed version of file with line 75 in wpautop() updated (sorry, no diff on this system)

[markjaquith]

patch for WP 1.6 SVN

[markjaquith]

Thanks! Patch added.

Excellent bug report, by the way. Much appreciated.

[ryan]

(In [4167]) Recognize paragraph tags with attributes when stripping breaks. Props rockinfree. fixes #1706

[ryan]

(In [4240]) Recognize paragraph tags with attributes when stripping breaks. Props rockinfree. fixes #1706

[(none)]

Milestone 2.0.5 deleted

[foolswisdom]

This actually created awkward behavior, which I have encountered working with numerous customers.

Most HTML includes line breaks through out it to easy readability. If within paragraph tags, the best assumption is that new lines <br />s will be explictly defined.

[hakre]

Please close as wontfix. Fixing things will break other things and vice-
versa. I do not know a single serious developer that wants to touch this.

Best would be to get a binding description first what must (not)/should (not)/can
(not) be done by wpautop. Then testcases must be written (executeable ones) and then the function can be developed accordingly.

related: #2833

[westi]

Agreed we need comprehensive autop test cases before touching the code in this way.

Moving to Future.

[hakre]

Related: #4857

[hakre]

Replying to westi:

Agreed we need comprehensive autop test cases before touching the code in this way.

Moving to Future.

Does this mean you agree with "not a single serious developer wants to touch this" as well?

[hakre]

Related: #2813

[nacin]

Most HTML includes line breaks through out it to easy readability. If within paragraph tags, the best assumption is that new lines <br />s will be explictly defined.

This is not related to the initial bug report, nor is it something that we would ever address at this point, as automatic line breaks are integral to wpautop.

Considering this fixed on 2.0.