WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17060 closed enhancement (duplicate)

Code cleanup in get_file_data()

Reported by: strider72 Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Plugins Keywords: has-patch
Focuses: Cc:

Description

The patch that originally introduced the get_file_data() function had a spot that was not PHP 4 compatible. The fix was a bit clunky, but necessary at the time.

Now that WordPress requires PHP 5, we can tidy things up a bit.

Absolutely no behavioral change here, just turning four lines of code into one line.

Original ticket: http://core.trac.wordpress.org/ticket/8964
Relevant commmentary: http://core.trac.wordpress.org/ticket/8964#comment:27

Attachments (1)

17060-cleanup.diff (646 bytes) - added by strider72 3 years ago.

Download all attachments as: .zip

Change History (4)

strider723 years ago

comment:1 strider723 years ago

Better relevant comment from original get_file_data() ticket:
http://core.trac.wordpress.org/ticket/8964#comment:35

comment:2 follow-up: scribu3 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Heh: #15743

comment:3 in reply to: ↑ 2 strider723 years ago

Replying to scribu:

Heh: #15743

LOL -- Scribu said in six letter what I said in six sentences!

Version 0, edited 3 years ago by strider72 (next)
Note: See TracTickets for help on using tickets.