Make $wp_query->query read-only

[scribu]

WP_Query has two properties that contain query vars:

$wp_query->query is the initial query.

$wp_query->query_vars is the "working copy", with all possible query vars filled.

I propose we prevent modification of $wp_query->query and keep it as a signature of that particular instance.

[scribu]

Note that attempts to modify $wp_query->query will just trigger a notice:

Notice: Indirect modification of overloaded property WP_Query::$query has no effect ...

[westi]

We already discussed in IRC how we can't really make anything private that wasn't private before because it could break plugin functionality.

While this won't cause a WSOD it could break sites.

[scribu]

We're not making it private, just read-only.

You can still call if ( 'bar' == $wp_query->query['foo'] ) etc.

[wonderboymusic]

@scribu, do you still feel this way? leaving this open for discussion

[wonderboymusic]

Not a lot of action here