WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#17082 closed defect (bug) (fixed)

White background missing in Thickbox when viewing plugin details

Reported by: andrewryno Owned by:
Milestone: 3.2 Priority: low
Severity: minor Version: 2.9
Component: UI Keywords: has-patch
Focuses: Cc:

Description

When viewing the details of a plugin you want to install, the background color is missing, so the tabs look cut off and awkward. It's being applied by the first declaration in colors-fresh.css/colors-classic.css. Put the patch in wp-admin.css since it needs to be white for both themes.

Before patch: http://d.pr/aLHa

After patch: http://d.pr/fRDk

Couldn't tell when this changed but tested against trunk, 3.1 and 3.0.4 and it seems to be an issue in those versions.

Attachments (4)

17082.diff (329 bytes) - added by andrewryno 10 years ago.
17082.patch (345 bytes) - added by ocean90 10 years ago.
17082.2.diff (696 bytes) - added by andrewryno 10 years ago.
Screenshot.png (103.3 KB) - added by studionashvegas 9 years ago.
Ubuntu 11.04 - Chrome: Tested before patch and white background is there. Anyone else seeing the background as not white?

Download all attachments as: .zip

Change History (8)

@andrewryno
10 years ago

@ocean90
10 years ago

#1 @ocean90
10 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Version changed from 3.1 to 2.9

It should use the same background color as for the media upload iframe, see 17082.patch. It's missing in 2.9 too.

Last edited 10 years ago by ocean90 (previous) (diff)

@andrewryno
10 years ago

#2 @andrewryno
10 years ago

Ah, nice catch. I didn't really think about looking to see where that background was declared. However, you missed colors-classic as well. New patch just adds it.

@studionashvegas
9 years ago

Ubuntu 11.04 - Chrome: Tested before patch and white background is there. Anyone else seeing the background as not white?

#3 @studionashvegas
9 years ago

Tested on firefox (also Ubuntu 11.04) with same result as above - white background is showing up fine.

WP build on both is 3.2beta1

Last edited 9 years ago by studionashvegas (previous) (diff)

#4 @andrewryno
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Likely fixed in #17324.

Note: See TracTickets for help on using tickets.