oEmbed - PollDaddy regex needs updating

[r-a-y]

PollDaddy's oEmbed regex needs updating so it correctly embeds.

Attached patch.

[nacin]

This will break old form URLs. The oembed handler should instead be adjusted to handle these. We could also remove the subdomain requirement and send all subdomains, but we shouldn't make it more restrictive (i.e. /poll/).

[r-a-y]

You're correct about hardcoding "/poll/".

Removing the subdomain will work.
New patch fixes this.

[r-a-y]

Escapes period.

[duck_]

I think we will want to add an escaped dot to the regex:

#http://(.+)?\.polldaddy\.com/.*#i

to avoid matching completely different domains, e.g. ​http://notpolldaddy.com/, and only allow polldaddy.com subdomains.

[r-a-y]

If you update the patch to add the dot, then would the following not match:

http://polldaddy.com/poll/xxx

I kind of copied the regex that Smugmug was using ;)
​http://core.trac.wordpress.org/browser/trunk/wp-includes/class-oembed.php#L46

[azaozz]

How about

#http://(.+\.)?polldaddy\.com/.*#i

[duck_]

In [19076]:

Fix polldaddy oEmbed regular expression to work with new style URLs. Props r-a-y, azaozz. Fixes #17106.