WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#17122 closed enhancement (fixed)

Set smiley conversion to disabled by default

Reported by: joostdevalk Owned by: nacin
Milestone: 3.4 Priority: normal
Severity: minor Version:
Component: General Keywords: easy-fix has-patch commit
Focuses: Cc:
PR Number:

Description

I've been setting up a blog for the European Patent Office lately, on http://blog.epo.org, and got a rather distressed call just now, because in a post they'd written, the text "8)" had been converted into a smiley. Simple enough to get rid of, by unchecking the default functionality for that on Settings -> Writing.

It did make me think though: this feature should NOT be on by default anymore, WordPress as a platform has gotten past that in my opinion. Agree?

Attachments (1)

17122.patch (461 bytes) - added by sksmatt 8 years ago.
removes the '8)' smiley

Download all attachments as: .zip

Change History (13)

#1 follow-up: @jane
8 years ago

I think we want to keep smilies on by default, but I agree that the one with the 8 is weird to auto-convert and it's the one that usually confuses things (the other strings are not common). How about we take out the one the 8 altogether?

#2 in reply to: ↑ 1 @nacin
8 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 3.4

Replying to jane:

How about we take out the one the 8 altogether?

Definitely okay with this.

#3 @SergeyBiryukov
8 years ago

  • Keywords needs-patch easy-fix added

Tagging to attract new contributors.

@sksmatt
8 years ago

removes the '8)' smiley

#4 @sksmatt
8 years ago

Looks like the right opportunity to try submitting a patch - hopefully I did it correctly.

#5 @SergeyBiryukov
8 years ago

  • Keywords has-patch added; needs-patch removed

#6 @SergeyBiryukov
8 years ago

  • Keywords commit added

#7 @dd32
8 years ago

Patch looks great.

Do we want to remove the file too? Or leave it around for plugins?

Sidenote: A new icon set for smilies would make sense one day...

#8 @nacin
8 years ago

I suggest we leave it around for plugins. It's all part of the same smiley set.

On commit, I'm thinking that instead of deleting the line, we should comment it out with a note, that way people know that A) it exists and B) it was deliberately disabled due to potential conflicts with regular text.

#9 @sksmatt
8 years ago

Replying to dd32:

Patch looks great.

Thank you!

Replying to nacin:

On commit, I'm thinking that instead of deleting the line, we should comment it out with a note, that way people know that A) it exists and B) it was deliberately disabled due to potential conflicts with regular text.

Would this be consider an appropriate comment style for this case?:

     ';-)' => 'icon_wink.gif',
     /* 
     *  NOTE: deliberately disabled due to potential conflicts with regular text. 
     *  The file exists and is available.
     *
     *  '8)' => 'icon_cool.gif',
     */
     '8O' => 'icon_eek.gif',

Also, I made some note variations as english grammar is not my strongest suit. Let me know if one of the following would do:

a)
Deliberately disabled due to potential conflicts with regular text. The file exists and is available.

b)
The following file exists but the smiley has been deliberately disabled due to potential conflicts with regular text.

c)
The file exists but the smiley has been deliberately disabled due to potential conflicts with regular text.

d)
The following smiley has been deliberately disabled due to potential conflicts with regular text but the file is still available.

#10 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19613]:

Disable the 8) smiley as it breaks regular text more than all of the others. props sksmatt. fixes #17122.

#11 follow-up: @nacin
8 years ago

No need to be pedantic over inline docs, it's all the same. Congrats on your first patch!

#12 in reply to: ↑ 11 @sksmatt
8 years ago

Replying to nacin:

No need to be pedantic over inline docs, it's all the same. Congrats on your first patch!

Amazing! this made my day, thanks guys.

Note: See TracTickets for help on using tickets.