WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 21 months ago

#17131 closed enhancement (fixed)

Make theme's content_width available in XML-RPC

Reported by: koke Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: mobile revert
Focuses: Cc:

Description

To upload properly sized images, being able to access the theme's $content_width variable from XML-RPC would help

Attachments (1)

17131.diff (753 bytes) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 nacin3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.2

comment:2 nacin3 years ago

Patch also needs to check if $content_width isn't set and return 0. Probably also needs an int cast.

nacin3 years ago

comment:3 daniloercoli3 years ago

  • Cc ercoli@… added

comment:4 josephscott3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17663]) Expose the content width as a read only option via XML-RPC.

Fixes #17131 props koke, nacin

comment:5 westi3 years ago

  • Cc westi added
  • Resolution fixed deleted
  • Status changed from closed to reopened

As I said in IRC when this was originally being discussed.

I'm not sure why the theme's content width matters during image upload - what happens when I switch to a wider theme later?

Should the app not be working the media settings which have already been exposed?

comment:6 ptahdunbar3 years ago

We should standardize accessing the $content_width var instead of doing it manually everywhere. Enter, get_content_width() - #17130

comment:7 nacin3 years ago

  • Keywords revert added; has-patch removed

Agreed on revert. I offered the patch before considering its usage. I was in IRC with westi and agreed then.

comment:8 ryan3 years ago

Revert per bug scrub.

comment:9 ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from reopened to closed

In [18119]:

Revert [17663]. fixes #17131

comment:10 ramiy21 months ago

Related: #21256

Note: See TracTickets for help on using tickets.