Static WP_I18N strings in wp-load

[niallkennedy]

Any reason why WP_I18N strings in wp-load need to be dynamic strings?

Patch to change to static strings.

[westi]

Our coding standards prefer the use of double quotes on a string that contains single quotes over escaping of the quote / apostrophe.

Closing as WONTFIX.

[niallkennedy]

text direction ans wp_die title as static text

[niallkennedy]

Modified patch to static strings for text direction and wp_die title. The wp_die message remains as dynamic string to adhere to coding standards.

[sivel]

Please do not over write patches when attaching a new patch. Doing so does not allow others to understand the context of comments made in regards to previous patches. If you do not select to replace, it will automatically increment the patch number or you can handle this on your own.

[niallkennedy]

Replying to sivel:

Please do not over write patches when attaching a new patch. Doing so does not allow others to understand the context of comments made in regards to previous patches. If you do not select to replace, it will automatically increment the patch number or you can handle this on your own.

Sorry for creating confusion.

The original patch changed three strings in wp-load from dynamic strings to static strings: WP_I18N_TEXT_DIRECTION; WP_I18N_NO_CONFIG; WP_I18N_ERROR_TITLE.

Westi noted my proposed change to WP_I18N_NO_CONFIG requires escaping the apostrophe in "doesn't" and therefore ​violates the WordPress Coding Standards.

The other two strings do not contain an apostrophe and therefore should be eligible for a change to a static string.

[westi]

(In [17645]) Switch some strings to single rather than double quotes in wp-load.php. Fixes #17160 props niallkennedy.