WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#17169 closed enhancement (fixed)

Dynamic strings to static strings in class-wp-xmlrpc-server

Reported by: niallkennedy's profile niallkennedy Owned by: westi's profile westi
Milestone: 3.2 Priority: lowest
Severity: trivial Version:
Component: XML-RPC Keywords: has-patch
Focuses: Cc:

Description

Converting associative array keys, comparison strings, and other strings from dynamic strings to static strings. Hundreds.

Attachments (1)

class-wp-xmlrpc-server.diff​ (24.5 KB) - added by niallkennedy 13 years ago.
static strings

Download all attachments as: .zip

Change History (3)

@niallkennedy
13 years ago

static strings

#1 @westi
13 years ago

  • Milestone changed from Awaiting Review to 3.2
  • Owner set to westi
  • Priority changed from normal to lowest
  • Severity changed from minor to trivial
  • Status changed from new to accepted

Thanks for this.

The XMLRPC code is old and existed before we had consistent coding standards.

Adding to my list for 3.2 - won't commit yet as I don't want to break the patches we already have on the bundle of XMLRPC enhancements Joseph is working on.

#2 @ryan
13 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [17823]:

Use static strings. Props niallkennedy. fixes #17169

Note: See TracTickets for help on using tickets.