previous_comments_link and next_comments_link return wrong url with PATHINFO permalinks

[FireMotion]

When using PATHINFO permalinks, previous_comments_link() and next_comments_link() return a wrong link, which renders paged comments useless.

Steps to reproduce:
Set permalinks to: /index.php/%post_id%/%postname%/

The functions return URLs similar to: /comments-page-1/#comments
This URL results in a file not found (if no rewrite rules are available, which should not be necessary if the PATHINFO permalink structure is used).

Expected URL: /index.php/comments-page-1/#comments
Manual opening the URL results in the expected/correct paged comments page.

[Viper007Bond]

Correct URL would be /index.php/123/post-name/comments-page-1/#comments, not the URL described.

[solarissmoke]

If I set permalinks to

/index.php/%post_id%/%postname%/

And I go to a post with comments, the previous comment link points to:

http://localhost/wp/index.php/26/hello-world/comment-page-1/#comments

Which works fine. Can you clarify what your actual and expected links are?

[FireMotion]

My apologies, I now realize some information is missing:

I'm using a static page as my front page (and am not using any posts).

This is why, in my initial post, wrote: /index.php/comments-page-1/#comments, which indeed should be the expected URL (which is confirmed working, when manually entering the URL in a browser).

I'm guessing this is the cause of the problems (and it's confirmed working on other pages that are not the front page).

[Viper007Bond]

Ah, so index.php is missing from the comment page links on the static page homepage. Got it.

[FireMotion]

Viper007Bond: Your summary is correct.
"index.php" is missing from the comment page links, when using paged comments, a static page and PATHINFO permalinks.

[c3mdigital]

This is caused by get_page_link()

	if ( 'page' == get_option( 'show_on_front' ) && $post->ID == get_option( 'page_on_front' ) )
		$link = home_url('/');

Patch adds a check for got_mod_rewrite() and if false prepends the permalink with index.php.

[wonderboymusic]

Let's find a way to unit test this

[nacin]

This doesn't look like the right place for a fix. Also, $wp_rewrite has the ability to return the pathinfo prefix — this can't be hardcoded.