Opened 13 years ago
Closed 13 years ago
#17194 closed defect (bug) (fixed)
Term intersection requests ignore non-existent terms.
Reported by: | ryan | Owned by: | scribu |
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Taxonomy | Keywords: | has-patch |
Focuses: | Cc: |
Description
Perform a term intersection such as tag=foo+bar. If foo doesn't exist then bar is queried solo, thus reducing the request to tag=bar. Intersections that include terms that do not exist should not return any terms.
Attachments (2)
Change History (12)
#5
@
13 years ago
I ended up using exceptions, since otherwise I would have to check for an error after each call to tranform_query(). I'm not a big fan of exception handling, but in self-contained cases like this, they come in handy.
#7
follow-up:
↓ 8
@
13 years ago
As I said, the point of using exceptions here is to avoid error checking at each step. You can't do that with WP_Error, unless it's made throwable.
#8
in reply to:
↑ 7
@
13 years ago
Replying to scribu:
As I said, the point of using exceptions here is to avoid error checking at each step. You can't do that with WP_Error, unless it's made throwable.
Yes. But using WP_Error and checking for it makes the code flow explicit and more readable and it how WordPress works.
I thought I fixed this. Obviously not.