WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 5 years ago

#17198 closed task (blessed)

New theme for 3.next -- Twenty Eleven — at Version 53

Reported by: matt Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords:
Focuses: Cc:

Description (last modified by lancewillett)

It's been a few years since we did this (#9015) but let's track the effort for the Twenty Eleven theme, hopefully making 3.2, here.

Main goals besides what we've already done in Twenty Ten:

  • To be different from Twenty Ten, aesthetically.
  • Is a good showcase of WP's headline features.
  • Clean, fast to load, and with best-practice markup.

Nice to have, but optional, improvements:

  • Ability to have random rotating headers. (Core improvement to custom header functionality, see #17240.)
  • Color and layout options.
  • More post formats. (Currently supports Asides, Links, and Galleries.)
  • CMS-style slider home page option.

Some people will prefer the design of Twenty Ten, which is still excellent, over Twenty Eleven, but that's okay. We'll have something new next year.

Change History (63)

#1 @aaroncampbell
5 years ago

  • Cc aaroncampbell added

@Jayjdk
5 years ago

Fix wrong html5.js path in header.php

@kawauso
5 years ago

Remove excessive whitespace

@kawauso
5 years ago

Remove excessive whitespace and standardise on \r\n

@kawauso
5 years ago

Make showcase.php query usage more efficient

#2 follow-ups: @dd32
5 years ago

Cross-referencing the commit:

matt in [17669]

Importing Duster theme, first pass at a candidate for twentyeleven theme.

Nice to have, but optional, improvements it'd be nice to have:

  • Ability to have random rotating headers. (Core improvement to custom header functionality.)
  • Color and layout options.
  • More post formats. (Currently supporst Asides, Links, and Galleries.)
  • CMS-style slider home page option.

Welcome, TwentyEleven n?\195?\169e Duster. :) Track at #17198.

Last edited 5 years ago by dd32 (previous) (diff)

#3 follow-up: @matt
5 years ago

Line endings should be svn:eol-style native, so \r\n or similar shouldn't matter. We should make the text files have Windows-style endings though, if they don't already.

#4 @nathanrice
5 years ago

  • Cc ncrice@… added

#5 @andrewryno
5 years ago

  • Cc andrewryno@… added

#6 @westi
5 years ago

(In [17670]) Set svn:eol-style on twentyeleven. See #17198

#7 in reply to: ↑ 3 @westi
5 years ago

Replying to matt:

Line endings should be svn:eol-style native, so \r\n or similar shouldn't matter. We should make the text files have Windows-style endings though, if they don't already.

I set svn:eol-style on the files - I suspect you may want to change it from native on readme and license based on this comment?

#8 @automattor
5 years ago

(In [17671]) Fix html5 js link. See #17198 props Jayjdk

#9 @westi
5 years ago

(In [17672]) Provide more arguments to the widgets on the 404 page so as to avoid notices. See #17198

#10 @linuxologos
5 years ago

  • Cc linuxologos@… added

#11 @mfields
5 years ago

  • Cc michael@… added

I submitted this patch which has been picked up for 3.2 which should fix the notice issues in TwentyEleven: #16761

#12 @iandstewart
5 years ago

  • Cc ian@… added

#13 in reply to: ↑ 2 @aaroncampbell
5 years ago

Replying to dd32:

Nice to have, but optional, improvements it'd be nice to have:

  • CMS-style slider home page option.

What exactly are you looking for here? Something like on http://www.fiftyandfifty.org/ or like http://xavisys.com or ???

#14 @jaredatch
5 years ago

  • Cc jaredatch added

#15 @dougal
5 years ago

  • Cc dougal@… added

#16 @pseudoxiah
5 years ago

  • Cc contact@… added

#17 @ocean90
5 years ago

  • Cc ocean90 added

#18 @Jayjdk
5 years ago

  • Cc Jayjdk added

#19 @lancewillett
5 years ago

  • Cc lance@… added

#20 @josephscott
5 years ago

  • Cc josephscott added

@iandstewart
5 years ago

Additional conditional IDs for the html element

#21 @iandstewart
5 years ago

17672.html-id.diff adds conditional ids for IE6 and IE8 for users who will be using Twenty Eleven as a parent theme and may have use for those ids (an id for IE7 was already present in Duster).

@kawauso
5 years ago

showcase.php cleanup, 2nd pass

#22 @smub
5 years ago

  • Cc smub added

#23 @kawauso
5 years ago

17198.showcase.2.diff adds full loop functionality back to the $featured query since we can't rely on sticky posts being available (may be trashed) and ensures all loop actions are fired correctly, while avoiding invoking it at all when no stickies are set.

Also makes better use of $feature_class and uses the native current post counter in the $recent query.

#24 @ocean90
5 years ago

iandstewart, 3.2 wil drop IE6 support, I think 2011 should drop it too.

#25 @azaozz
5 years ago

3.2 is marked as EOL for IE6 (for the admin), however themes (front end) should still support it so they have best compatibility. There are still people that are stuck in IE6. For them the admin would have limited functionality but the front end site should work.

Last edited 5 years ago by azaozz (previous) (diff)

#26 @toscho
5 years ago

  • Cc info@… added

#27 @hd-J
5 years ago

  • Cc contact@… added

@iandstewart
5 years ago

Support for Status and Quote Formats

#28 @iandstewart
5 years ago

17672.status-quote-formats.diff adds support for Status and Quote format display, excludes those formats from the Showcase Recent Posts, and adds them to the posts included in the custom "Ephemera" widget. It also adds CSS section headers for each Format and the 404 styles in style.css.

#29 @batmoo
5 years ago

  • Cc batmoo@… added

#30 @wikichaves
5 years ago

  • Cc wikichaves added

@markmcwilliams
5 years ago

Allows the /twentyeleven/ directory to be added, for anyone using the WordPress Beta Tester plugin, and updating nightly.

#31 @markmcwilliams
5 years ago

I was hoping the above patch would solve the /twentyeleven/ directory being included in any updates used from within your dashboard, if you used say the WordPress Beta Tester plugin. Turns out I already had the theme there, after I uploaded it myself. But I'm finding that /twentyeleven/ isn't included when I went from 3.1.1 to 3.2-bleeding, so I can't try it out online!

#32 follow-up: @dd32
5 years ago

I was hoping the above patch would solve the /twentyeleven/ directory being included

I'll take care of that tomorrow

#33 in reply to: ↑ 32 @markmcwilliams
5 years ago

Replying to dd32:

I was hoping the above patch would solve the /twentyeleven/ directory being included

I'll take care of that tomorrow

Cool, thanks. Obviously a little more work needed than adding a line of code? ;)

#34 follow-ups: @dd32
5 years ago

Adding that line should've done it. However, it should be fine as '3.2', and it also needs to be set in the file -during- the 3.1.x -> 3.2 update, ie. within the update zip. There may be other things at play here though, so I'll check it during testing.

@matveb
5 years ago

Minor style fixes (overflow) for international blogs and replacing em dash with the proper CSS value for the entity.

#35 @matveb
5 years ago

  • Cc mv@… added

#36 in reply to: ↑ 2 @lancewillett
5 years ago

Replying to dd32:

  • Ability to have random rotating headers. (Core improvement to custom header functionality.)

Added #17240 to track work on new random image rotation feature. This should be available to all themes (not just the new default theme).

#37 @lancewillett
5 years ago

Added #17242 to track work for allowing custom height for header images.

#38 @lancewillett
5 years ago

(In [17714]) Twenty Eleven: strip trailing spaces, props kawauso - see #17198

#39 @lancewillett
5 years ago

(In [17717]) Twenty Eleven: add support for Status and Quote formats, props iandstewart - see #17198

#40 @lancewillett
5 years ago

(In [17718]) Twenty Eleven: add additional conditional IDs for the html element, props iandstewart - see #17198

#41 @lancewillett
5 years ago

(In [17719]) Twenty Eleven: minor style fixes (overflow) for international blogs and replacing em dash with the proper CSS value for the entity. Props matveb, see #17198

#42 @hebbet
5 years ago

  • Cc pascal.herbert@… added

#43 @saracannon
5 years ago

  • Cc sararcannon@… added

#44 @sabreuse
5 years ago

  • Cc sabreuse added

#45 @lancewillett
5 years ago

(In [17720]) Twenty Eleven: move widgets.php into /inc - see #17198

#46 follow-up: @nickbohle
5 years ago

  • Cc mail@… added

#47 @iandstewart
5 years ago

(In [17721]) Twenty Eleven: functions.php cleanup and introduction of theme options; see #17198

  • Cleanup functions.php, adding comments and function_exists() checks following Twenty Ten's example
  • Theme option for choosing an alternate (dark) color scheme. It currently only loads a placeholder CSS file with dark styles to follow.
  • Theme option for selecting a link color that loads an internal style block for resetting link colors. An updated style.css will follow to take advantage of this.
  • Theme options for selecting an alternate layout. Adds a class to the body element. An updated style.css will follow to take advantage of this.

#48 follow-up: @greenshady
5 years ago

Can we set a default case for the switch statement in the twentyeleven_comment() function? It would be as simple as moving the first check down to the bottom and changing the case to:

default :

Currently, this function handles the comment, trackback, and pingback comment types. All other comment types are skipped. By default, WordPress core functionality handles custom comment types just fine.

This is also an issue in the TwentyTen theme and now many, many themes being submitted to the theme repository because so many theme authors just copy/paste code from the default WordPress theme.

#49 in reply to: ↑ 48 ; follow-up: @lancewillett
5 years ago

Replying to greenshady:

Can we set a default case for the switch statement in the twentyeleven_comment() function?

Makes sense to me, plus it's a good practice in programming in general to have a default case for switch statements. Patch looks good, thanks Justin.

#50 follow-up: @lancewillett
5 years ago

(In [17722]) Twenty Eleven: set default case for switch statement in the twentyeleven_comment(), props greenshady - see #17198

#51 @lancewillett
5 years ago

(In [17723]) Twenty Eleven: fix spacing and add a few missing esc_attr() calls in widgets.php - see #17198

#52 @lancewillett
5 years ago

Related to Twenty Eleven (but should work with any theme), I added a patch for #17240 that will load a random image from the theme's registered header images.

Note: Twenty Eleven only has one header image right now (more coming soon), so test it out with Twenty Ten.

#53 @lancewillett
5 years ago

  • Description modified (diff)
  • Summary changed from New theme for 3.next -- TwentyEleven to New theme for 3.next -- Twenty Eleven
Note: See TracTickets for help on using tickets.