WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#17212 closed defect (bug) (fixed)

Within the ThickBox gallery, the .pinkynail image's display toggling behavior is weird.

Reported by: goto10 Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Gallery Keywords: has-patch
Focuses: Cc:

Description

Different clicking sequences between the individual and all show/hide controls will cause the pinkynail to be either hidden when it should be shown, or vice versa.

To reproduce the issue:

1.) Go into a post, and click the "Add Image" button to launch the ThickBox iframe.
2.) Either upload some new images or use a post that already has some images attached.
3.) Click the "Gallery" tab.
4.) Click the "Show" link for one single media item.
5.) Click the "All Tabs: Show" link
6.) Finally, click the "All Tabs: Hide" link.

The pinkynail image for the individual media item clicked in step 4 will not be toggled back into display.

This simple patch forces the pinkynail to be hidden when showing all, and shown when hiding all.

Attachments (1)

gallery.dev.js.diff (642 bytes) - added by goto10 4 years ago.
Replaced previous patch with one created from the root directory

Download all attachments as: .zip

Change History (8)

comment:1 @goto104 years ago

  • Cc dromsey@… added

By the way, the patch is for the file: /wp-admin/js/gallery.dev.js

comment:2 follow-up: @andrewryno4 years ago

I saw you mentioned this was your first patch in the #wordpress-dev channel, but when you run svn diff to generate a diff file, you can run it from the root of the install to automatically show the full path of the file being edited. Also works better when editing multiple files. Just a heads up if you keep contributing (which you should)!

comment:3 in reply to: ↑ 2 ; follow-up: @goto104 years ago

Replying to andrewryno:

I saw you mentioned this was your first patch in the #wordpress-dev channel, but when you run svn diff to generate a diff file, you can run it from the root of the install to automatically show the full path of the file being edited. Also works better when editing multiple files. Just a heads up if you keep contributing (which you should)!

Thanks andrewwryno. Yes indeed, this is my first contribution, so I appreciate the advice. Should I create a new patch from the root, or is it OK as is (and just go from root in the future)?

comment:4 in reply to: ↑ 3 @andrewryno4 years ago

Replying to goto10:

Replying to andrewryno:
Thanks andrewwryno. Yes indeed, this is my first contribution, so I appreciate the advice. Should I create a new patch from the root, or is it OK as is (and just go from root in the future)?

Commiters/testers prefer from root, but it's a small patch so I think it's fine.

@goto104 years ago

Replaced previous patch with one created from the root directory

comment:5 @SergeyBiryukov4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

comment:6 @jane3 years ago

  • Component changed from General to Gallery

comment:7 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18851]:

Toggle the pinkynails properly, props goto10, fixes #17212

Note: See TracTickets for help on using tickets.