Walker_PageDropdown doesn't filter titles correctly

[Otto42]

The Walker_PageDropdown has this code:

$title = esc_html($page->post_title);
$title = apply_filters( 'list_pages', $page->post_title );

Meaning that the esc_html is not applied properly, since $title just gets replaces with the $post_title again.

Fix is this:

$title = esc_html($page->post_title);
$title = apply_filters( 'list_pages', $title );

Patch attached.

[nacin]

Going to tweak this a bit. Instead moving the esc_html() to after the filter, consistent with escaping as late as possible and also still passing post_title unescaped to the filter, as before.

[nacin]

(In [17683]) Apply esc_html properly in Walker_PageDropdown. fixes #17217.

[nacin]

Broken in [16446].

[nacin]

(In [17685]) Apply esc_html properly in Walker_PageDropdown. fixes #17217 for the 3.1 branch.