get_posts_by_author_sql() should use the post type object

[nacin]

The filter there, pub_priv_sql_capability, is pretty useless, particularly since it doesn't receive any context. Suggesting we simply remove it.

Patch also adds a $post_type property to count_many_users_posts().

[nacin]

Untested.

[PeteMall]

Fixed typos

[PeteMall]

Tested with a custom column and using count_many_users_posts() with a custom post type.

[nacin]

Alternative for keeping the filter should be this:

if ( ! $cap = apply_filters( 'pub_priv_sql_capability', '' ) )
     $cap = $post_type_obj->cap->read_private_posts;

Rather than applying the filter over read_private_posts, given its historical usage.

[nacin]

Either way, we should also remove the various comments about pub_priv_sql_capability() in the phpdoc for get_private_posts_cap_sql(), which is where the filter was introduced in r5189.

[nacin]

(In [17742]) Use the post type object in get_posts_by_author_sql() and add a post type parameter to count_many_users_posts(). The formerly somewhat useless and now totally useless pub_priv_sql_capability filter is considered deprecated. fixes #17220.