Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#17226 closed enhancement (fixed)

border radius for help & screen options in Opera

Reported by: hebbet Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:


opera 11.10 doesn't render the buttom corners rounded like Firefox or Chrome because css3 border-radius is missing

Attachments (3)

border radius opera.patch (119.0 KB) - added by hebbet 7 years ago.
border radius opera-1.patch (456 bytes) - added by hebbet 7 years ago.
border-radius-khtml ticket 17226.patch (1.4 KB) - added by hebbet 7 years ago.

Download all attachments as: .zip

Change History (16)

#1 @scribu
7 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 3.2

Please don't set the has-patch keyword unless you upload a diff file that fixes the problem.

#2 @hebbet
7 years ago

  • Keywords has-patch added; needs-patch removed

#3 @hebbet
7 years ago

patch added

#4 @ocean90
7 years ago

Thx for the patch; for the future, patch for the dev file is enough.

#5 @nacin
7 years ago

I imagine this isn't the only place we're defining -moz or -webkit without border-radius?

We should do a sweep and be consistent. All four in every appropriate instance: -webkit, -khtml, -moz, border-radius.

#6 @nacin
7 years ago

(In [17750]) Define border-radius with vendor properties. props hebbet, see #17226.

#7 @hebbet
7 years ago

I tested it one my sites and that two boxes were the only not rounded boxes.

I will go the current admin css files and post a comment when i find another file.

#8 @hebbet
7 years ago

I found the following: in wp-admin.css a.button,a.button-primary,a.button-secondary: only webkit #contextual-help-link-wrap: khtml missing .pressthis a has -o-border-radius, no khtml

in wp-admin-rtl.css #post-body ul.add-menu-item-tabs li.tabs: no khtml.

Will add a patch tomorrow

#9 follow-up: @ocean90
7 years ago

khtml, do we really need this?

7 years ago


#10 @hebbet
7 years ago

added patch.

I am not sure about a.button,a.button-primary,a.button-secondary (has only Webkit), so i didn't added it to my patch

#11 in reply to: ↑ 9 @markjaquith
7 years ago

  • Keywords 2nd-opinion added

Replying to ocean90:

khtml, do we really need this?

We do seem to support it in some places.

#12 @nacin
7 years ago

This should get a final review - considering the mouse-nibbled corner commits, I think we're good here?

#13 @koopersmith
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing this as fixed. Open a new ticket if you find any missing vendor prefixes.

Note: See TracTickets for help on using tickets.