WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#17232 closed enhancement (maybelater)

Remove the star HTML hack for IE6

Reported by: ocean90 Owned by:
Milestone: Priority: low
Severity: normal Version: 3.1
Component: Administration Keywords: has-patch needs-refresh
Focuses: Cc:

Description

WordPress 3.2 will drop IE6 support for the admin screen.

Some admin stylesheets still include the star HTML hack to fix some odd IE6 bugs.

The patch will remove the code blocks because they aren't needed anymore.

Attachments (2)

17232.patch (7.3 KB) - added by ocean90 7 years ago.
17232.2.patch (885 bytes) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (16)

@ocean90
7 years ago

#1 @scribu
7 years ago

Isn't IE7 also affected?

#2 @scribu
7 years ago

I guess it won't, based on the Wikipedia article.

#3 @ocean90
7 years ago

Right, it's a special selector for IE 4 to 6 which was fixed with IE 7, see Root node selection.

#4 @azaozz
7 years ago

  • Keywords close added

Well, we are stopping support for IE6, doesn't mean we have to kill it completely :-) Think we can leave the existing CSS as is, especially in ie.css.

#5 @scribu
7 years ago

  • Keywords close removed

That's like saying "we are stopping support for PHP4, doesn't mean we have to fix #16918".

#6 @nacin
7 years ago

  • Keywords close added

No, it's really not.

Perhaps we can concentrate this stuff in ie.dev.css.

#7 @scribu
7 years ago

Please explain why it's not the same. I don't get it.

#8 follow-up: @dd32
7 years ago

Droping IE6 support is more of a symbolic thing, It should still function in IE6, it's just that we're no longer going to write code specifically to support it.

If we write a new admin screen for example, it might work in every browser and IE9, Another line of CSS will make it work in IE7/8. If it's going to require a JS hack to make it work in IE6, then ignore IE6 as it's "not supported". However, If that line of CSS for IE7 can also fix it for IE6, then so be it.

If it currently works in IE6, no reason to break it, just don't pull your hair out trying to support it..

The patch for example removes 10 lines from the admin bar css file, If I was writing the admin bar css today, I'd still include those as it's minimal and due to the admin bar being shown on the front screen for some sites (ie. BuddyPress powered sites or similar) and it's not a purely admin-based functionality.

#9 in reply to: ↑ 8 @ocean90
7 years ago

  • Keywords needs-patch added; has-patch close removed

Replying to dd32:

The patch for example removes 10 lines from the admin bar css file, If I was writing the admin bar css today, I'd still include those as it's minimal and due to the admin bar being shown on the front screen for some sites (ie. BuddyPress powered sites or similar) and it's not a purely admin-based functionality.

That's right my mistake.

+1 for scribu's argument and +1 for dd32 argument.

Solution: Try to concentrate this stuff in ie.dev.css, nacin's point, and close it as maybelater. Compromise? :)

@ocean90
7 years ago

#10 @ocean90
7 years ago

  • Keywords has-patch added; needs-patch removed

17232.2.patch:

  • Press this doesn't include the IE stylesheet
  • #themeselect isn't used anymore
  • #template is used for the theme/plugin editor, so transfer it into IE stylesheet

#11 @ocean90
7 years ago

  • Milestone changed from 3.2 to Future Release

#13 @helen
5 years ago

  • Keywords needs-refresh close added

I don't see any more of the * html hacks in the main stylesheet now, and there's an IE6 leftovers section in ie.css. Do we really need to specifically remove it, or can it just ride?

#14 @ocean90
5 years ago

  • Keywords close removed
  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement
Note: See TracTickets for help on using tickets.