Make WordPress Core

Opened 7 years ago

Last modified 7 weeks ago

#17262 reviewing enhancement

wp_get_attachment_thumb_file is always false — at Version 12

Reported by: lonnylot Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version: 3.0
Component: Media Keywords: good-first-bug needs-unit-tests has-patch
Focuses: Cc:

Description (last modified by DrewAPicture)

The issue is that on line 3863 we always search for $imagedata['thumb'] and it never exists. Instead we have $imagedata['thumbnail']. This always exists.

Change History (16)

7 years ago

#1 @scribu
7 years ago

  • Keywords has-patch removed

Please submit patches as svn diffs. Tutorials can be found on the trac homepage.

Last edited 7 years ago by scribu (previous) (diff)

7 years ago

wp-includes/post.php diff

#2 @lonnylot
7 years ago

Sorry for the delay! Added the correct diff off of trunk rev. 18191

#3 @nacin
7 years ago

  • Version changed from 3.2 to 3.0

So does wp_get_attachment_thumb_file() ever work? That function should probably be deprecated in favor of the various other functions now.

#4 @lonnylot
7 years ago

As far as I can tell not unless you add a custom image type called 'thumb'

#5 @azaozz
7 years ago

@nacin is right, deprecate +1.

#6 @scribu
7 years ago

  • Keywords needs-patch 3.3-early added
  • Milestone changed from Awaiting Review to Future Release

#7 @tw2113
6 years ago

  • Cc michael.d.beckwith@… added

#8 @wonderboymusic
6 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 3.6

17262.2.diff updates wp_get_attachment_thumb_file() so it works in trunk. The previous patch did not have current code in mind. It's not immediately obvious to me what wp_get_attachment_thumb_file() and wp_get_attachment_thumb_url() would be deprecated in favor of.

#9 @nacin
5 years ago

'thumb' is the old-style thumbnail, prior to proper intermediate sizes ('thumbnail' / 'medium' / 'large').

wp_get_attachment_thumb_url() does return the newer 'thumbnail' if it exists, and falls back to wp_get_attachment_thumb_file() if it does not.

You can see a bit of code history in image_downsize(): "fall back to the old thumbnail" in a code comment.

Not sure what _file() should return in a deprecated situation. _url() is basically the old-school form of wp_get_attachment_image_src( $size = 'thumbnail' ), which returns array( $src, $width, $height ). Which is kind of lame.

So, perhaps they can both be updated to work on 'thumbnail', and then left, as wp_get_attachment_thumb_url() is definitely easier, nicer, and more obvious to use than wp_get_attachment_image_src()['url'], and according to MarkJaquith, is widely used by plugins (probably for that reason).

Last edited 5 years ago by SergeyBiryukov (previous) (diff)

#10 @SergeyBiryukov
5 years ago

#23556 was marked as a duplicate.

5 years ago

This one first checks for the "fall back to the old thumbnail" and if that returns false then goes ahead and checks according to the revised array

#11 @SergeyBiryukov
5 years ago

#10492 was marked as a duplicate.

#12 @DrewAPicture
5 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.