UI: Missing comments count in admin screen

[ramiy]

See Attached image.

[scribu]

I'm pretty sure it's just a technical limitation, due to the fancy river of comments we have.

[scribu]

@ramiy: The owner field is meant either for the person that supplies the patch or that oversees the ticket (i.e. a commiter).

[scribu]

If you want to signal that the patch works for you, just leave a comment saying so.

[chexee]

Patch works for me.

[ocean90]

Can't see a problem with the small patch.

Because we are showing the same line on the Dashboard now too (see [17797]) we should implant it in 3.2 to be consistent.

[ramiy]

Replying to scribu:

@ramiy: The owner field is meant either for the person that supplies the patch or that oversees the ticket (i.e. a commiter).

Ok, Thanks for the feedback. I have reassignd the ticket to @solarissmoke (the patch supplier).

[jane]

Didn't make it in by freeze, revisit for 3.3.

[ramiy]

Also, we need to hide the "tabs" when the count is 0 (zero).

In posts and pages, for example, we don't see "Draft (0)" or "Trash (0)".

Same principle should be in comments, the Pending/Spam/Trash should be hidden when count in zero.

[ramiy]

Show approved-comments before moderated-comments, based on solarissmoke patch

[ramiy]

Show approved-comments before moderated-comments, based on solarissmoke patch

[ramiy]

Patch tested. Looks great. Check the attached screenshot.

[ryan]

Punting enhancements from 3.3.

[duck_]

The patch doesn't work because it's showing the total number of comments, but the "All" view only displays approved and pending comments and not spammed ones.

For example with 2 approved comments, 2 pending comments and 1 spam comment I see "All (5)" but actually only 4 items are listed.

[duck_]

Any patch also has to deal with the JavaScript count updating too, i.e. decrementing the "All" and "Approved" counts when a comment is trashed/spammed.

[ramiy]

Replying to duck_:

The patch doesn't work because it's showing the total number of comments, but the "All" view only displays approved and pending comments and not spammed ones.

I tested the patch few months ago, it worked for me (See the ​screenshot). Where there any changes that could effect the comments count?

[duck_]

Replying to ramiy:

I tested the patch few months ago, it worked for me (See the ​screenshot).

If you look at the actual number of items being displayed and the count on the right (under the search box) you should only see the two approved comments and "2 items". I think it's confusing having "All (18)" as the view 'title' when 18 comments aren't being shown.

[ramiy]

Replying to duck_:

If you look at the actual number of items being displayed and the count on the right (under the search box) you should only see the two approved comments and "2 items". I think it's confusing having "All (18)" as the view 'title' when 18 comments aren't being shown.

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

I usually look at "Published" post count (don't care about drafts/trash). Same for comments, i am more intrested in "Approved" comments (don't care about spam/trash)

[SergeyBiryukov]

Replying to ramiy:

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

On Posts/Pages screens, the "All" tab only includes published, draft and pending posts.

Likewise, on Comments screen, the "All" tab only includes approved and pending comments.

[duck_]

Replying to ramiy:

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

Trashed posts don't count towards the "All" count on the posts screen. And with the patch applied trashed comments don't either only spammed ones.

Edit: apologies for the double posting with Sergey.

[ramiy]

So what do you suggest to do?

You want to remove the "Spam" and "Trash" from the total count ("All" tab) ?

[wonderboymusic]

Approved comment count shown via [33655]

[afercia]

Approved comment count shown via [33655]

Very special thanks to @wonderboymusic for fixing all this stuff :) To have an idea of the amount of work done see #11200 and #32362. If I'm not mistaken, now that there's a correct count for "All" (approved and pending comments) it should be possible to show and dynamically update the count for "All".

[wonderboymusic]

In 34506:

Comments List Table: include count for "All". Dynamically update.

Fixes #17275.

[afercia]

In 34508:

Comments List Table: fix the translators comment for all count after [34506].

See #17275.

[ramiy]

In posts/pages/cpt and media, when no items found - you don't see the other tabs. The same should apply for comments, hiding Pending, Approved, Spam and Trash labels when they are empty.