WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 19 months ago

#17275 assigned enhancement

UI: Missing comments count in admin screen

Reported by: ramiy Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.2
Component: Comments Keywords: has-patch
Focuses: ui Cc:

Description

See Attached image.

Attachments (6)

count.jpg (64.0 KB) - added by ramiy 4 years ago.
count-marked.jpg (20.5 KB) - added by ramiy 4 years ago.
17275.diff (1.9 KB) - added by solarissmoke 4 years ago.
17275.2 (1.6 KB) - added by ramiy 4 years ago.
Show approved-comments before moderated-comments, based on solarissmoke patch
17275.2.diff (1.8 KB) - added by ramiy 4 years ago.
Show approved-comments before moderated-comments, based on solarissmoke patch
count-tested.jpg (4.7 KB) - added by ramiy 4 years ago.

Download all attachments as: .zip

Change History (31)

@ramiy4 years ago

@ramiy4 years ago

comment:1 @scribu4 years ago

  • Component changed from UI to Comments
  • Keywords needs-patch added; ui-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Severity changed from major to normal

I'm pretty sure it's just a technical limitation, due to the fancy river of comments we have.

@solarissmoke4 years ago

comment:2 @solarissmoke4 years ago

  • Keywords has-patch added; needs-patch removed

comment:3 @ramiy4 years ago

  • Owner set to ramiy
  • Status changed from new to accepted

comment:4 follow-up: @scribu4 years ago

  • Owner ramiy deleted
  • Status changed from accepted to assigned

@ramiy: The owner field is meant either for the person that supplies the patch or that oversees the ticket (i.e. a commiter).

Last edited 4 years ago by scribu (previous) (diff)

comment:5 @scribu4 years ago

If you want to signal that the patch works for you, just leave a comment saying so.

comment:6 @chexee4 years ago

Patch works for me.

comment:7 @ocean904 years ago

  • Milestone changed from Future Release to 3.2
  • Severity changed from normal to minor

Can't see a problem with the small patch.

Because we are showing the same line on the Dashboard now too (see [17797]) we should implant it in 3.2 to be consistent.

comment:8 in reply to: ↑ 4 @ramiy4 years ago

  • Owner set to solarissmoke

Replying to scribu:

@ramiy: The owner field is meant either for the person that supplies the patch or that oversees the ticket (i.e. a commiter).

Ok, Thanks for the feedback. I have reassignd the ticket to @solarissmoke (the patch supplier).

comment:9 @jane4 years ago

  • Milestone changed from 3.2 to Future Release

Didn't make it in by freeze, revisit for 3.3.

comment:10 @ramiy4 years ago

Also, we need to hide the "tabs" when the count is 0 (zero).

In posts and pages, for example, we don't see "Draft (0)" or "Trash (0)".

Same principle should be in comments, the Pending/Spam/Trash should be hidden when count in zero.

@ramiy4 years ago

Show approved-comments before moderated-comments, based on solarissmoke patch

@ramiy4 years ago

Show approved-comments before moderated-comments, based on solarissmoke patch

comment:11 @SergeyBiryukov4 years ago

  • Milestone changed from Future Release to 3.3

comment:12 @ramiy4 years ago

Patch tested. Looks great. Check the attached screenshot.

@ramiy4 years ago

comment:13 @ryan4 years ago

  • Milestone changed from 3.3 to Future Release

Punting enhancements from 3.3.

comment:14 @ramiy4 years ago

  • Type changed from enhancement to defect (bug)

comment:15 @jane3 years ago

  • Owner solarissmoke deleted
  • Type changed from defect (bug) to enhancement

comment:16 follow-up: @duck_3 years ago

  • Keywords needs-patch added; has-patch removed

The patch doesn't work because it's showing the total number of comments, but the "All" view only displays approved and pending comments and not spammed ones.

For example with 2 approved comments, 2 pending comments and 1 spam comment I see "All (5)" but actually only 4 items are listed.

comment:17 @duck_3 years ago

Any patch also has to deal with the JavaScript count updating too, i.e. decrementing the "All" and "Approved" counts when a comment is trashed/spammed.

comment:18 in reply to: ↑ 16 ; follow-up: @ramiy3 years ago

Replying to duck_:

The patch doesn't work because it's showing the total number of comments, but the "All" view only displays approved and pending comments and not spammed ones.

I tested the patch few months ago, it worked for me (See the screenshot). Where there any changes that could effect the comments count?

comment:19 in reply to: ↑ 18 ; follow-up: @duck_3 years ago

Replying to ramiy:

I tested the patch few months ago, it worked for me (See the screenshot).

If you look at the actual number of items being displayed and the count on the right (under the search box) you should only see the two approved comments and "2 items". I think it's confusing having "All (18)" as the view 'title' when 18 comments aren't being shown.

comment:20 in reply to: ↑ 19 ; follow-ups: @ramiy3 years ago

Replying to duck_:

If you look at the actual number of items being displayed and the count on the right (under the search box) you should only see the two approved comments and "2 items". I think it's confusing having "All (18)" as the view 'title' when 18 comments aren't being shown.

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

I usually look at "Published" post count (don't care about drafts/trash). Same for comments, i am more intrested in "Approved" comments (don't care about spam/trash)

Last edited 3 years ago by ramiy (previous) (diff)

comment:21 in reply to: ↑ 20 @SergeyBiryukov3 years ago

Replying to ramiy:

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

On Posts/Pages screens, the "All" tab only includes published, draft and pending posts.

Likewise, on Comments screen, the "All" tab only includes approved and pending comments.

comment:22 in reply to: ↑ 20 @duck_3 years ago

Replying to ramiy:

It's not confusing, just like in posts/pages screen the "All" tab includes the trashed posts, in comments it includes the trash+spam comments.

Trashed posts don't count towards the "All" count on the posts screen. And with the patch applied trashed comments don't either only spammed ones.

Edit: apologies for the double posting with Sergey.

Last edited 3 years ago by duck_ (previous) (diff)

comment:23 @ramiy3 years ago

So what do you suggest to do?

You want to remove the "Spam" and "Trash" from the total count ("All" tab) ?

comment:24 @ramiy3 years ago

  • Keywords has-patch ui-feedback added; needs-patch removed
  • Severity changed from minor to normal

comment:25 @helen19 months ago

  • Focuses ui added
  • Keywords ui-feedback removed
Note: See TracTickets for help on using tickets.