WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#17282 closed enhancement (fixed)

Dashboard Recent Comments "View All" replacement

Reported by: jane Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: minor Version: 3.1
Component: UI Keywords: has-patch
Focuses: Cc:

Description

The "View All" buttons on the dashboard boxes are weird b/c they are buttons, but they aren't actions, they are links. Would like to start switching over to a standard where buttons are mostly reserved for action/commitments, not just links to another screen.

Suggestions for Recent Comments box: instead of "View All" button, replace with links to the various views of the comments screen. So:

View All | Pending (24) | Approved | Spam (6) | Trash (3)

...where the link styles are the same as on edit-comments.php

Attachments (4)

dashboard.php.patch (180 bytes) - added by ryanimel 7 years ago.
Tweak of Dashboard Recent Comments widget
dashboard.dev.css.patch (77 bytes) - added by ryanimel 7 years ago.
Remove float from .subsubsub in widget
dashboard.css.patch (11.8 KB) - added by ryanimel 7 years ago.
dashboard_recent_comments.diff (877 bytes) - added by ryanimel 7 years ago.
This one should be correct. Sorry about the misstep.

Download all attachments as: .zip

Change History (15)

#1 @ocean90
7 years ago

That would be the same as for the right now box, isn't it a repetition?

#2 @nacin
7 years ago

I believe the end goal would be to free up that space in the Right Now box for something else.

#3 @ryanimel
7 years ago

  • Cc ryanimel added

I don't actively use the Right Now box, so even if both boxes had these links it would be useful for me.

I put the list of views in the widget, removed the View All button. One thought I have, now that I see it there working: should the views be at the top of the Recent Comments box, rather than the bottom? Then again that might seem to indicate filtering would happen within the box itself, rather than linking off to another place.

@ryanimel
7 years ago

Tweak of Dashboard Recent Comments widget

@ryanimel
7 years ago

Remove float from .subsubsub in widget

#4 follow-up: @ryanimel
7 years ago

  • Keywords has-patch added; needs-patch removed

#5 @jane
7 years ago

The goal is not to free up the Right Now box, the goal is to use buttons and links appropriately, and treat each box independently. A lot of people hide Right Now but keep Recent Comments. If we update Right Now and remove those items because they seem less important as standalone items there than they did in 2008 when we designed it, that would be a separate thing.

#6 in reply to: ↑ 4 @azaozz
7 years ago

Replying to ryanimel:

Hmm, seems something went wrong when creating or uploading the patches. Don't see anything in them. Also no need to do the minimized JS and CSS, the committer will do it when adding them. Please have a look here https://core.trac.wordpress.org/wiki#HowtoSubmitPatches

#7 follow-up: @markjaquith
7 years ago

ryanimel — also, don't include minified files when making patches. Just patch the .dev.css or .dev.js versions. Less work for you, and less likely that they'll get out of sync if the committer is the one who minifies it.

#8 in reply to: ↑ 7 @ryanimel
7 years ago

Replying to azaozz:

Thanks, I figured I'd swing and miss here at first. New patch now, should be okay.

Replying to markjaquith:

That makes sense, will do.

@ryanimel
7 years ago

This one should be correct. Sorry about the misstep.

#9 @ryan
7 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [17797]:

Change View All Buttons into plain links. Show full set of status links in recent comments box. Drop Change Theme button.Props ryanimel. fixes #17282

#10 @scribu
6 years ago

Similar: #18306

#11 @ramiy
6 years ago

Related: #17275

Note: See TracTickets for help on using tickets.