Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#17295 closed defect (bug) (fixed)

String 'Deactivate' needs context on widget page

Reported by: ocean90 Owned by:
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch
Focuses: Cc:


On the widget screen:

<h3><?php _e('Available Widgets'); ?> <span id="removing-widget"><?php _e('Deactivate'); ?> <span></span></span></h3></div>

On the plugin screen 'Deactivate' is 'Deaktivieren' in German, but on the widget screen we need 'Deaktiviere' for 'Deactivate'. Patch will add a context to the string.

Attachments (1)

17295.patch (848 bytes) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (6)

7 years ago

#1 @ocean90
7 years ago

Another solution would be to use printf():

printf( ('Deactivate %s'), '<span></span>');

Would be in German "%s deaktivieren" which would be good too.

Version 0, edited 7 years ago by ocean90 (next)

#2 @scribu
7 years ago

What would the %s be in this case?

#3 @ocean90
7 years ago

It would be <span></span> which is later the widget title (added via JS).

#4 @scribu
7 years ago

  • Milestone changed from Awaiting Review to 3.2

Nah, should use _x(), as in your patch.

#5 @ryan
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.