WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 10 months ago

#17328 closed defect (bug) (fixed)

In User Profile, Undefined property: WP_User::$rich_editing line 189 user-edit

Reported by: anmari Owned by: wonderboymusic
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.2
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:

Description

Notice: Undefined property: WP_User::$rich_editing in C:\web\wpbeta\wp\wp-admin\user-edit.php on line 189
/>

Attachments (2)

17328.diff (1.0 KB) - added by sorich87 3 years ago.
Adds empty check
17328.2.patch (1.0 KB) - added by c3mdigital 11 months ago.

Download all attachments as: .zip

Change History (11)

comment:1 ocean903 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Tested on current trunk. Can't see the notice.

Please provide some steps to reproduce it if you still get the message.

comment:2 anmari3 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Hi,

I updated to 3.2-beta1-17999 and re-tested.

Does NOT happen on own profile.

Does happen on other profiles when navigating to that profile. Now says line 199.

Notice: Undefined property: WP_User::$rich_editing in C:\web\wpbeta\wp\wp-admin\user-edit.php on line 199

comment:3 nacin3 years ago

The rich_editing meta key probably doesn't exist for the user. Not sure it's a bug as I don't think you can create a user without that any longer.

There's an empty() check on comment_shortcuts. Can probably tack that onto rich_editing as well for sanity reasons.

sorich873 years ago

Adds empty check

comment:4 sorich873 years ago

  • Keywords has-patch added

comment:5 ocean903 years ago

  • Component changed from General to Warnings/Notices
  • Milestone set to Awaiting Review

comment:6 c3mdigital11 months ago

  • Keywords needs-refresh added

c3mdigital11 months ago

comment:7 c3mdigital11 months ago

  • Keywords needs-refresh removed

comment:8 SergeyBiryukov11 months ago

  • Milestone changed from Awaiting Review to 3.7

comment:9 wonderboymusic10 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 25330:

Check $profileuser->rich_editing for empty before using it in Edit User admin code.

Props sorich87, c3mdigital.
Fixes #17328.

Note: See TracTickets for help on using tickets.