WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 8 years ago

#17328 closed defect (bug) (fixed)

In User Profile, Undefined property: WP_User::$rich_editing line 189 user-edit

Reported by: anmari Owned by: wonderboymusic
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.2
Component: Warnings/Notices Keywords: has-patch
Focuses: Cc:

Description

Notice: Undefined property: WP_User::$rich_editing in C:\web\wpbeta\wp\wp-admin\user-edit.php on line 189
/>

Attachments (2)

17328.diff (1.0 KB) - added by sorich87 11 years ago.
Adds empty check
17328.2.patch (1.0 KB) - added by c3mdigital 8 years ago.

Download all attachments as: .zip

Change History (11)

#1 @ocean90
11 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Tested on current trunk. Can't see the notice.

Please provide some steps to reproduce it if you still get the message.

#2 @anmari
11 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Hi,

I updated to 3.2-beta1-17999 and re-tested.

Does NOT happen on own profile.

Does happen on other profiles when navigating to that profile. Now says line 199.

Notice: Undefined property: WP_User::$rich_editing in C:\web\wpbeta\wp\wp-admin\user-edit.php on line 199

#3 @nacin
11 years ago

The rich_editing meta key probably doesn't exist for the user. Not sure it's a bug as I don't think you can create a user without that any longer.

There's an empty() check on comment_shortcuts. Can probably tack that onto rich_editing as well for sanity reasons.

@sorich87
11 years ago

Adds empty check

#4 @sorich87
11 years ago

  • Keywords has-patch added

#5 @ocean90
11 years ago

  • Component changed from General to Warnings/Notices
  • Milestone set to Awaiting Review

#6 @c3mdigital
8 years ago

  • Keywords needs-refresh added

@c3mdigital
8 years ago

#7 @c3mdigital
8 years ago

  • Keywords needs-refresh removed

#8 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.7

#9 @wonderboymusic
8 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 25330:

Check $profileuser->rich_editing for empty before using it in Edit User admin code.

Props sorich87, c3mdigital.
Fixes #17328.

Note: See TracTickets for help on using tickets.