Twenty Eleven: link color option for dark theme does not show in admin

[cklosows]

When updating to use the 'Dark' version of the Twenty Eleven theme, the 'Link Color' does not update to the proper default color for the Dark CSS (#E4741F). It remains stating the default color is (#1b8be0). The rendering of the page does use the correct CSS Color.

Screencaps attached

[cklosows]

The Theme Options Area

[cklosows]

Theme uses correct color on render still though.

[cklosows]

I forgot to mention, that the field to edit the link color does save any changes, this only effects the default colors.

[nacin]

Patch welcome on this, otherwise I'll get to it in a day or so.

[cklosows]

I'll try and get a patch done this weekend.

[lancewillett]

Thanks cklosows. Your patch looks like a great start, but I'd like to see the default color value also be correct when loading the page (not just after a radio input change). Also, the hex value in the color input field and the color swatch should not change if a user has gone with a custom color.

I'll cook up an update to the patch and post it here.

[lancewillett]

Uses correct default value on page load, JS improvements

[studionashvegas]

Tested - works great. Sidenote: non-default colors DO remain even upon theme switch.

[nacin]

Not using worksforme correctly - those are for bugs we can't reproduce and are therefore invalid.

I have a better idea on this patch so hold off on commit.

[studionashvegas]

Ah, sorry about that. Will know for next time.

[nacin]

Attached patch:

• Registers default colors to each color scheme.
• Introduces twentyeleven_get_default_link_color( $color_scheme = null ) to select the default color based on the color scheme.
• Changes the default color when the scheme is switched, and if the old default was in use, then it is transitioned to the new default.
• Properly handles the scheme-specific default link color in the save handler.
• Adds width/height parameters to the theme layout and color scheme images, to prevent repaint on load.

Note that nothing is hardcoded, thus continuing to allow color schemes to be added via a filter.

[dcowgill]

Updated diff to the latest in trunk.

[nacin]

In [18198]:

Twenty Eleven: Properly handle the default link color for the dark theme. props dcowgill for the patch refresh. fixes #17351.