Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#17352 closed enhancement (fixed)

Avoid unnecessary multiple output buffers in admin-ajax get-comments

Reported by: mitchoyoshitaka Owned by: mitchoyoshitaka
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Performance Keywords: has-patch
Focuses: Cc:


In the admin-ajax get-comments code, there's currently a loop over each list table item in order to build up the comments HTML, but it creates, gets, and clears the output buffer for each of these loops. This probably could be collapsed into one output buffer?

Attachments (1)

17352.diff (719 bytes) - added by mitchoyoshitaka 3 years ago.

Download all attachments as: .zip

Change History (3)

mitchoyoshitaka3 years ago

comment:1 scribu3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.2
  • Type changed from defect (bug) to enhancement

comment:2 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [17897]:

Move output buffering out of a loop, collapsing it into one buffer. props mitchoyoshitaka, fixes #17352.

Note: See TracTickets for help on using tickets.