Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#17352 closed enhancement (fixed)

Avoid unnecessary multiple output buffers in admin-ajax get-comments

Reported by: mitchoyoshitaka Owned by: mitchoyoshitaka
Priority: normal Milestone: 3.2
Component: Performance Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

In the admin-ajax get-comments code, there's currently a loop over each list table item in order to build up the comments HTML, but it creates, gets, and clears the output buffer for each of these loops. This probably could be collapsed into one output buffer?

Attachments (1)

17352.diff (719 bytes ) - added by mitchoyoshitaka 15 years ago.

Download all attachments as: .zip

Change History (3)

#1 @scribu
15 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review3.2
  • Type defect (bug)enhancement

#2 @nacin
15 years ago

  • Resolutionfixed
  • Status newclosed

In [17897]:

Move output buffering out of a loop, collapsing it into one buffer. props mitchoyoshitaka, fixes #17352.

Note: See TracTickets for help on using tickets.