Opened 14 years ago
Closed 14 years ago
#17358 closed defect (bug) (fixed)
in_admin_footer shouldn't be in p.alignleft
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch dev-feedback |
Focuses: | Cc: |
Description
There's currently no way to add something that is INSIDE the admin footer but NOT inside the p#footer-left.alignleft
I recommend we move the in_admin_footer action to be inside the footer div but NOT inside the p tag.
Attachments (1)
Change History (7)
#1
@
14 years ago
- Keywords has-patch dev-feedback added
- Milestone changed from Awaiting Review to 3.2
#2
@
14 years ago
There are 79 plugins in the repository that use this hook. *None* of them would break if we moved it. The worst case scenario actually affects nearly all of them (70ish) and would be that their text/links would be styled differently in the footer because they're no longer in the p tag. Here's a list of all of them:
- Everything would still work, but the text and links (mostly "this site is running version of " type attribution links, some of them asking for donations or linking to wishlists) would be in the div not the p so the style would be a little different:
- Memepost
- Reveal IDs
- Admin Menus Fixed
- Similar Posts
- FeedCache Pipes
- Role Scoper
- Bulk Delete
- Ozh' Admin Drop Down Menu
- Random Posts
- Secure WordPress
- tbk Creative's Social Float
- SyntaxHighlighter TinyMCE Button
- Custom Upload Dir
- Quiz
- IdeaScale
- Exhibit to WP Gallery
- Smooth Gallery Replacement
- GigPress
- WP-SimpleViewer
- Recent Posts
- Ozh' Better Feed
- Easy retweet
- Graceful Pull-Quotes
- Last Modified Footer
- Liz Comment Counter by Ozh
- Audio Player
- FBFoundations Facebook Chicklet
- Popular Posts
- E-Mail Log
- Audio Player
- Recent Comments
- GD Press Tools - Optionally outputs some stats as well as the attribution links
- MicroPoll
- ©Feed
- Feed Cache
- Github Ribbon
- K2 Style Switcher
- New User E-Mail Setup
- Google Doc Embedder
- FB Share
- Category Icons
- Repost.Me Icon Bar
- WP-dTree
- Twitter Avatar Reloaded
- wp-irc
- Bulk Move
- Fluency Admin
- WP Audiencc
- WP Easy Stats
- Member Access
- WP Year End Stats
- WP Footer Ad
- Cleverness To-Do List
- AddQuicktag
- FeedStats
- WP jQuery Lightbox
- Typekit plugin for WordPress
- Simple Yearly Archive
- CalendarPress
- Occasions
- JS AnsiSpam
- open-flash-chart-core
- Tweetbacks Helper
- Lim4wp
- SEO Booster Lite
- Adminimize
- WP Prosperent Plugin
- Text Control
- SEO Ultimate
- Geo Mark
- Just removes the browse_happy hook which already doesn't exist
- Uses it as a checkpoint where it checks and reports runtime
- Would actually benefit from the change
- PayPal Digital Goods powered by Cleeng - Outputs a form wrapped in a div
- Aioseo Multibyte Descriptions - Displays messages in p tags wrapped in divs
- Cleeng Content Monetization - Outputs a form wrapped in a div
- Just includes another plugin:
- Dashboard Editor - Seems to just include Ozh' Admin Drop Down Menu which is already listed above
- Actually uses it:
- Show SVN Revision - Just displays some text and links showing you what svn revision you're running *if* it can access
- WP Cache Inspect - Adds a cache flush link
- WP SyntaxHighlighter - Includes JS
#3
@
14 years ago
#17323 definitely isn't using this. I'd still like to see this in sooner rather than later because we're only going to collect more plugins that are using it, making it more difficult to justify changing it. The change is minor and won't break ANY plugins at the moment (although plugin text added to the footer may be styled a little differently, but we're changing a lot of styles anyway).
This would be helpful if we're putting #17323 in the footer.