Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#17358 closed defect (bug) (fixed)

in_admin_footer shouldn't be in p.alignleft

Reported by: aaroncampbell Owned by: westi
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch dev-feedback
Focuses: Cc:


There's currently no way to add something that is INSIDE the admin footer but NOT inside the p#footer-left.alignleft

I recommend we move the in_admin_footer action to be inside the footer div but NOT inside the p tag.

Attachments (1)

17358.diff (754 bytes) - added by aaroncampbell 5 years ago.

Download all attachments as: .zip

Change History (7)

5 years ago

#1 @aaroncampbell
5 years ago

  • Keywords has-patch dev-feedback added
  • Milestone changed from Awaiting Review to 3.2

This would be helpful if we're putting #13723 in the footer.

Version 0, edited 5 years ago by aaroncampbell (next)

#2 @aaroncampbell
5 years ago

There are 79 plugins in the repository that use this hook. *None* of them would break if we moved it. The worst case scenario actually affects nearly all of them (70ish) and would be that their text/links would be styled differently in the footer because they're no longer in the p tag. Here's a list of all of them:

#3 @aaroncampbell
4 years ago

#17323 definitely isn't using this. I'd still like to see this in sooner rather than later because we're only going to collect more plugins that are using it, making it more difficult to justify changing it. The change is minor and won't break ANY plugins at the moment (although plugin text added to the footer may be styled a little differently, but we're changing a lot of styles anyway).

#4 @ryan
4 years ago

No objections here.

#5 @westi
4 years ago

Looks good to me too. committing.

#6 @westi
4 years ago

  • Owner set to westi
  • Resolution set to fixed
  • Status changed from new to closed

In [18147]:

Move the in_admin_footer action out of p#footer-left.alignleft so it is just in div#footer to allow for it to be used more flexibly. Fixes #17358 props aaroncampbell.

Note: See TracTickets for help on using tickets.