WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#17359 closed defect (bug) (fixed)

Themes: update allowed theme tags with new WP features

Reported by: lancewillett Owned by: nacin
Milestone: 3.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch i18n-change commit
Focuses: Cc:

Description

Update the "wporg_theme_feature_list" to include tags for newer WP features so themes can denote they support the feature.

  • featured-image-header
  • featured-images
  • full-width-template
  • post-formats

Most of those features were added in Twenty Ten default theme and will exist in Twenty Eleven default theme as well.

Patch also adds missing "gray" tag to the color list.

Attachments (1)

theme-tags-update.diff (2.4 KB) - added by lancewillett 9 years ago.

Download all attachments as: .zip

Change History (13)

#1 @Otto42
9 years ago

same tags added to org, will add to theme check shortly.

#2 @lancewillett
9 years ago

Would be cool to get this is in 3.2 because of the default theme (we missed it for Twenty Ten).

#3 @nacin
9 years ago

  • Milestone changed from Awaiting Review to 3.2

#4 follow-up: @nacin
9 years ago

What is "Full-Width Template"?

I'm thinking "featured-images" and "post-formats" are the two major ones we should support. Stuff like featured-image-header sounds pretty niche, despite both of our default themes supporting it. (Something we should probably stop with now.)

#5 @nacin
9 years ago

  • Keywords i18n-change added

Suggesting we break the freeze on this one.

#6 @nacin
9 years ago

Suggesting commit as otherwise we'll have English words show up via the API. The alternative to committing this would be to removing the tags until 3.3.

#7 in reply to: ↑ 4 @lancewillett
9 years ago

Replying to nacin:

What is "Full-Width Template"?

The theme has a page template that is full-width, no sidebar. It's a popular search query when end users are searching for themes.

I'm thinking "featured-images" and "post-formats" are the two major ones we should support. Stuff like featured-image-header sounds pretty niche, despite both of our default themes supporting it. (Something we should probably stop with now.)

I'm fine with dropping "featured-image-header" if the other three get in. Adding the missing color tag would be nice, too.

#8 @nacin
9 years ago

  • Keywords commit added

Suggest commit on the whole diff. I'll plead to the translators.

#9 @azaozz
9 years ago

To all of them? Commit +1.

#10 follow-up: @nacin
9 years ago

Should Full-Width have a hyphen?

#11 in reply to: ↑ 10 @lancewillett
9 years ago

Replying to nacin:

Should Full-Width have a hyphen?

If I were writing it in prose the correct formatting would be "Full-width Template" — but I'd vote here for readability instead, using three full words in title case. Purposefully eschewing orthographic and grammatical standards for ease of scanning in the filter list.

#12 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18327]:

Add theme feature strings for translation. These are already being returned by the API. props lancewillett, fixes #17359.

Note: See TracTickets for help on using tickets.