get_page_by_path() returns deleted posts

[mark8barnes]

I think the title is self-explanatory. This behaviour is counter-intuitive, as deleted posts aren't retrievable by the path. If the existing behaviour needs to remain for backwards compatibility, there should be an extra parameter added so deleted posts can be optionally excluded.

[nacin]

get_page_by_path() does no checks on post status. That means it also returns drafts, pending posts, future posts, and the like. You need to validate the post_status coming from the return value.

[mark8barnes]

Perhaps its just the name that's confusing. I expect this function to return posts that are accessible by a URI. Maybe it should have been called get_page_by_slug()

[nacin]

path is not a URI, it's just part of one. This isn't the slug, because the slug pertains only to that page, rather than the entire hierarchy. Hope that makes sense.

URI: ​http://example.com/about/team/

Path: /about/team/

Slug: /team/