WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#17362 closed defect (bug) (wontfix)

Use NCRs and boolean attribute with value=attribute's canonical name in Twenty Eleven

Reported by: peaceablewhale Owned by: iandstewart
Milestone: Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The Twenty Eleven theme is currently using HTML entities to represent some Unicode characters and XHTML-incompatible boolean attribute form. This breaks the page when served as "application/xhtml+xml".

Attachments (1)

17362.patch (31.3 KB) - added by peaceablewhale 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @peaceablewhale
6 years ago

Added a well-formness fix for the input element in theme-options.php.

#2 @holizz
6 years ago

  • Cc tom@… added

#3 @peaceablewhale
6 years ago

  • Owner set to iandstewart
  • Status changed from new to reviewing

#4 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.2

Input closures, #8217, and pubdate="pubdate" are all fine. We're not compliant with xhtml+xml.

Version 0, edited 6 years ago by nacin (next)

#5 @westi
6 years ago

  • Component changed from Themes to Bundled Theme

#6 @westi
6 years ago

Please don't replace named entities with magic numbers

Please don't patch auto-generated files.

#7 @iandstewart
6 years ago

  • Resolution set to wontfix
  • Status changed from reviewing to closed

Marking this one as wontfix.

#8 @SergeyBiryukov
3 years ago

  • Milestone 3.2 deleted
Note: See TracTickets for help on using tickets.