Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 17 months ago

#17362 closed defect (bug) (wontfix)

Use NCRs and boolean attribute with value=attribute's canonical name in Twenty Eleven

Reported by: peaceablewhale Owned by: iandstewart
Milestone: Priority: normal
Severity: normal Version: 3.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


The Twenty Eleven theme is currently using HTML entities to represent some Unicode characters and XHTML-incompatible boolean attribute form. This breaks the page when served as "application/xhtml+xml".

Attachments (1)

17362.patch (31.3 KB) - added by peaceablewhale 4 years ago.

Download all attachments as: .zip

Change History (9)

@peaceablewhale4 years ago

comment:1 @peaceablewhale4 years ago

Added a well-formness fix for the input element in theme-options.php.

comment:2 @holizz4 years ago

  • Cc tom@… added

comment:3 @peaceablewhale4 years ago

  • Owner set to iandstewart
  • Status changed from new to reviewing

comment:4 @nacin4 years ago

  • Milestone changed from Awaiting Review to 3.2

Input closures, #8217, and pubdate="pubdate" are all fine. We're not compliant with xhtml+xml.

Version 0, edited 4 years ago by nacin (next)

comment:5 @westi4 years ago

  • Component changed from Themes to Bundled Theme

comment:6 @westi4 years ago

Please don't replace named entities with magic numbers

Please don't patch auto-generated files.

comment:7 @iandstewart4 years ago

  • Resolution set to wontfix
  • Status changed from reviewing to closed

Marking this one as wontfix.

comment:8 @SergeyBiryukov17 months ago

  • Milestone 3.2 deleted
Note: See TracTickets for help on using tickets.