WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#17364 closed defect (bug) (fixed)

Validate the HTML in the admin area

Reported by: peaceablewhale Owned by: ryan
Milestone: 3.2 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Well-formness fixes for WordPress Admin interface

Attachments (4)

17364.patch (4.1 KB) - added by peaceablewhale 3 years ago.
17364.html-valid.patch (17.8 KB) - added by ocean90 3 years ago.
17364-wp-users-list-table.diff (807 bytes) - added by xknown 3 years ago.
Use esc_url instead of esc_html in /wp-admin/includes/class-wp-users-list-table.php
17364.2.patch (5.5 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 dd323 years ago

wp-admin/includes/class-wp-terms-list-table.php

The usage of wp_nonce_url without a nonce isn't ideal. You're probably looking for esc_url() or similar there

peaceablewhale3 years ago

comment:2 peaceablewhale3 years ago

Changed, thanks! :)

ocean903 years ago

comment:3 ocean903 years ago

  • Cc nacin added
  • Milestone changed from Awaiting Review to 3.2
  • Summary changed from Well-formness fixes for WordPress Admin interface to Validate the HTML in the admin area

Added a patch to make the admin area HTML valid on some pages again.

One problem still exists: ID "awaiting-mod" already defined on each page when a comment is in moderation because now the collapsed menu shows also the bubble.

comment:4 ryan3 years ago

In [18010]:

Validation fixes. Props ocean90, peaceablewhale. see #17364

xknown3 years ago

Use esc_url instead of esc_html in /wp-admin/includes/class-wp-users-list-table.php

comment:5 ocean903 years ago

xknown, the problem was, that through esc_url() it becomes something like &#...

My mistake, xknown is right.

Last edited 3 years ago by ocean90 (previous) (diff)

ocean903 years ago

comment:6 ocean903 years ago

17364.2.patch includes a fix for the ID "awaiting-mod" already defined issue. Use class instead of id.

comment:7 ryan3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [18114]:

Validation fixes. Props ocean90, xknown. fixes #17364

comment:8 ryan3 years ago

In [18115]:

Validation fixes. Props ocean90, xknown. fixes #17364

Note: See TracTickets for help on using tickets.